hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6471) StringBuffer -> StringBuilder - conversion of references as necessary
Date Wed, 06 Jan 2010 10:39:54 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797053#action_12797053
] 

Steve Loughran commented on HADOOP-6471:
----------------------------------------

I'm +1 to going s/StringBuffer/r/StringBuilder/ inside methods, but this patch also changes
some of the public methods in classes in contrib/failmon, which could have compatibility issues.
Better to omit those, or, if there is a pressing need to change their signature, switch them
to returning a string or a char sequence, either of which will hide the details of how the
string is built up


> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-6471
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6471
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Kay Kay
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6471.patch
>
>
> Across hadoop-common codebase,  a good number of StringBuffer-s being used are actually
candidates for StringBuilders , since the reference does not escape the scope of the method
and no concurrency is needed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message