hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6489) Findbug report: LI_LAZY_INIT_STATIC, OBL_UNSATISFIED_OBLIGATION
Date Thu, 14 Jan 2010 23:50:54 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800431#action_12800431
] 

Suresh Srinivas commented on HADOOP-6489:
-----------------------------------------

minor comments:
# Please move FileContext.localFsSingleton to the beginning of the class with the rest of
the static variables.
# CompressionCodeFactory.java space after java.io.InputStream to align variables is not needed.
Also new code needs to be formatted better (though the guidelines are loose here!)


> Findbug report: LI_LAZY_INIT_STATIC, OBL_UNSATISFIED_OBLIGATION
> ---------------------------------------------------------------
>
>                 Key: HADOOP-6489
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6489
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs, io, util
>    Affects Versions: 0.22.0
>            Reporter: Erik Steffl
>            Assignee: Erik Steffl
>             Fix For: 0.22.0
>
>         Attachments: HDFS-6489.patch
>
>
> From findbug report:
> Method org.apache.hadoop.io.compress.CompressionCodecFactory.main(String[]) may fail
to clean up java.io.OutputStream
> Incorrect lazy initialization of static field org.apache.hadoop.fs.FileContext.localFsSingleton
in org.apache.hadoop.fs.FileContext.getLocalFSFileContext()
> Incorrect lazy initialization of static field org.apache.hadoop.util.ReflectionUtils.serialFactory
in org.apache.hadoop.util.ReflectionUtils.getFactory(Configuration)
> Given that these have simple fixes I think one bug is enough.
> This is from findbug 1.3.9 running on current trunk:
> Path: .
> URL: http://svn.apache.org/repos/asf/hadoop/common/trunk
> Repository Root: http://svn.apache.org/repos/asf
> Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68
> Revision: 898558
> Node Kind: directory
> Schedule: normal
> Last Changed Author: tomwhite
> Last Changed Rev: 897023
> Last Changed Date: 2010-01-07 13:43:38 -0800 (Thu, 07 Jan 2010)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message