Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 6020 invoked from network); 14 Dec 2009 21:43:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 14 Dec 2009 21:43:40 -0000 Received: (qmail 6595 invoked by uid 500); 14 Dec 2009 21:43:40 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 6562 invoked by uid 500); 14 Dec 2009 21:43:40 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 6552 invoked by uid 99); 14 Dec 2009 21:43:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Dec 2009 21:43:40 +0000 X-ASF-Spam-Status: No, hits=-10.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Dec 2009 21:43:38 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 49109234C4B3 for ; Mon, 14 Dec 2009 13:43:18 -0800 (PST) Message-ID: <1800193578.1260826998297.JavaMail.jira@brutus> Date: Mon, 14 Dec 2009 21:43:18 +0000 (UTC) From: "Aaron Kimball (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Commented: (HADOOP-6438) Add configuration getters/setters to serialization classes In-Reply-To: <1372993065.1260584298202.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790388#action_12790388 ] Aaron Kimball commented on HADOOP-6438: --------------------------------------- > A package feels like overkill to me. Do we expect more than a single class? Depends? There are currently two ways to set the metadata: In most cases, setting the serialized class name is sufficient. (e.g., JavaSerialization, WritableSerialization, AvroSpecificSerialization). In the AvroGenericSerialization case, though, we set the schema to serialize, using an analogous but distinct API. We could maybe add a single class that contains methods like {{setMapOutputKeyClass()}} and {{setMapOutputKeySchema()}}; the current implementation breaks these apart, making the serialization system being used more explicit in the class name to which the configuration method belongs. I could go either way on this issue. > Add configuration getters/setters to serialization classes > ---------------------------------------------------------- > > Key: HADOOP-6438 > URL: https://issues.apache.org/jira/browse/HADOOP-6438 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Aaron Kimball > Assignee: Aaron Kimball > Attachments: HADOOP-6438.patch > > > Needed for MAPREDUCE-1126, getter and setter methods to inject specific metadata into configurations to (de)serialize various data types. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.