Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Message-ID: <1666490148.1260929778095.JavaMail.jira@brutus>
Date: Wed, 16 Dec 2009 02:16:18 +0000 (UTC)
From: "Aaron Kimball (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-6443) Serialization classes accept
 invalid metadata
In-Reply-To: <400559474.1260929658273.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-6443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791131#action_12791131 ] 

Aaron Kimball commented on HADOOP-6443:
---------------------------------------

The accept methods of the serializers check whether SERIALIZATION_CLASS equals the current class name. If so, they accept unconditionally, even though they contain further (unreachable) logic to ensure that they contain the requisite metadata (e.g., an avro schema or a class name).

The check should work in the opposite direction: if the user specifies SERIALIZATION_CLASS and it does not equal the current class name, then the serialization should reject the metadata. If the SERIALIZATION_CLASS equals the current class name, or is simply unset, then the serialization should inspect the remainder of the metadata to ensure that it meets the criteria associated with the current serialization.


> Serialization classes accept invalid metadata
> ---------------------------------------------
>
>                 Key: HADOOP-6443
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6443
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>         Attachments: HADOOP-6443.patch
>
>
> The {{SerializationBase.accept()}} methods of several serialization implementations use incorrect metadata when determining whether they are the correct serializer for the user's metadata.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.