hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6422) permit RPC protocols to be implemented by Avro
Date Mon, 14 Dec 2009 17:53:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790261#action_12790261

Doug Cutting commented on HADOOP-6422:

> (minor) should we be really having .* imports.

These were pre-existing.  The patch renames two files that included these, so the diff makes
it look like new code.  I attempted to change existing code as little as possible.

> -1 to logging the engine choice at info

Oops.  That was for debugging and not meant to remain.  I just removed it.

> This changes the signature of some public methods; so needs to be marked up as a change
that is incompatible at the source level.

Yes, it does require recompilation.  However the signature it changed (getProxy) is one whose
result is always cast before it can be used, so no calling source code in fact needs to change,
it only needs to be recompiled.  We expect that folks will recompile for new releases anyway,
don't we?  I run 'ant clean' whenever I pull from subversion, and I don't think we generally
intend for things to work for folks who don't.

> RPC.waitForProxy with a timeout needs to be public [ ... ]
> RPC.waitForProxy also needs to be interruptible [ ... ]

This patch does not change this one way or the other.  These are pre-existing problems not
addressed by this patch, no?

> permit RPC protocols to be implemented by Avro
> ----------------------------------------------
>                 Key: HADOOP-6422
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6422
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: ipc
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 0.22.0
>         Attachments: HADOOP-6422.patch, HADOOP-6422.patch, HADOOP-6422.patch, HADOOP-6422.patch,
> To more easily permit Hadoop to evolve to use Avro RPC, I propose to change RPC to use
different implementations for clients and servers based on the configuration.  This is not
intended as an end-user configuration: only a single RPC implementation will be supported
in a given release, but rather a tool to permit us to more easily develop and test new RPC
implementations.  As such, the configuration parameters used would not be documented.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message