hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amareshwari Sriramadasu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6439) Shuffle deadlocks on wrong number of maps
Date Thu, 17 Dec 2009 06:12:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791800#action_12791800
] 

Amareshwari Sriramadasu commented on HADOOP-6439:
-------------------------------------------------

Some comments on the patch:
1. 
{code}
          if (finalParameter) {
            finalParameters.add(attr);
          }
{code}
The above code is outside the check for value!= null, but it is moved inside in the patch.
Please make sure it is outside.

2. Shall we divide the test into two tests to simplify? First test tests the order of loading,
Second one tests final parameters and order of loading.
3. Can you add asserts for the values after every loadResource?
4. Can you add test to verify null values for the final parameters?

> Shuffle deadlocks on wrong number of maps
> -----------------------------------------
>
>                 Key: HADOOP-6439
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6439
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Blocker
>             Fix For: 0.21.0, 0.22.0
>
>         Attachments: HADOOP-6439-1.patch, mr-1252.patch
>
>
> The new shuffle assumes that the number of maps is correct. The new JobSubmitter sets
the old value. Something misfires in the middle causing:
> 09/12/01 00:00:15 WARN conf.Configuration: mapred.job.split.file is deprecated. Instead,
use mapreduce.job.splitfile
> 09/12/01 00:00:15 WARN conf.Configuration: mapred.map.tasks is deprecated. Instead, use
mapreduce.job.maps
> But my reduces got stuck at 2 maps / 12 when there were only 2 maps in the job.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message