hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6420) String-to-String Maps should be embeddable in Configuration
Date Mon, 14 Dec 2009 23:37:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790449#action_12790449
] 

Chris Douglas commented on HADOOP-6420:
---------------------------------------

bq. That could be fun to boostrap. DefaultStringifier uses SerializationFactory which could
use DefaultStringifier to find the serializer's metadata. [...]

This is not what I'm talking about. The Stringifier interface obviously doesn't require something
as general as DefaultStringifier and nobody has argued that a Map<String,String> is
wrong. The issue is whether the current patch offers the best approach to render the metadata
to the serialization; its superiority to big, blobby stuff is not obvious. By noting that
efforts to push non-primitive types into Configuration has a precedent and an interface, I
did not intend to advocate for a pluggable meta-serialization layer on top of Configuration.

bq. Note that we don't need to filter the entire configuration unless someone iterates over
the subset. [...]

Returning a Map from Configuration and restricting its range is cleaner and easier to explain.
If iteration isn't required, then this approach sounds good to me.

bq. If we did need to support iteration, then perhaps we could change Configuration to use
treemap, but that might open other cans of worms.

Agreed. After seeing MAPREDUCE-1183, I'm hoping that fewer components will rely on this class.

> String-to-String Maps should be embeddable in Configuration
> -----------------------------------------------------------
>
>                 Key: HADOOP-6420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6420
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>         Attachments: HADOOP-6420.2.patch, HADOOP-6420.3.patch, HADOOP-6420.4.patch, HADOOP-6420.patch
>
>
> Per MAPREDUCE-1126, we need to be able to take a map of (key, value) pairs and embed
that inside a Configuration object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message