hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6427) Add Path isQualified
Date Fri, 11 Dec 2009 18:28:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789434#action_12789434

Eli Collins commented on HADOOP-6427:

The namenode does not validate links, just accepts and returns link targets. See {{createSymlink}}
in FileContext in HADOOP-6421 and {{testCreateLinkToNonExistantFile}} in HDFS-245. The question
is whether when a file context creates a symlink should it make it fully qualified, ie 
hdfsFC.createSymlink("/foo", link);   //  Create a link to /foo or or hdfs://nn:port/foo?
localFC.getFileStatus(link); // ie should this now access /foo in this current file context
or hdfs://nn:port/foo?  
The code currently assumes the latter, that creating a link to /foo from an hdfs file context
should link to a file on that hdfs. Do you agree or prefer the other behavior. Either way
I'll add another cross-file system test to HDFS-245 that illustrates the behavior (whichever
we choose).

> Add Path isQualified
> --------------------
>                 Key: HADOOP-6427
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6427
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hadoop-6427-1.patch
> The Path class has a method to make a path qualified but not to query if the path is
qualified. This is needed for HADOOP-64221. In addition this patch adds tests to TestPath
that cover the file scheme. Note that "fully qualified" applies to domain names not URIs so
this function and it tests also serve to define what we mean by a fully qualified path.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message