hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6222) Core doesn't have TestCommonCLI facility
Date Fri, 11 Dec 2009 22:44:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789584#action_12789584
] 

Konstantin Boudnik commented on HADOOP-6222:
--------------------------------------------

I've ran local test-patch verification for Common part and all seems cool:
{noformat}
There appear to be 1 release audit warnings before the patch and 0 release audit warnings
after applying the patch.

-1 overall.
    +1 @author.  The patch does not contain any @author tags.
    +1 tests included.  The patch appears to include 12 new or modified tests.
    +1 javadoc.  The javadoc tool did not generate any warning messages.
    -1 javac.  The patch appears to cause tar ant target to fail.
    +1 findbugs.  The patch does not introduce any new Findbugs warnings.
    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.
{noformat}

The warning shown is related to the TestCLI class renaming, which has to be addressed by SVN
not patch program. Tests ran just fine.

There two ways of integrating this:
- do verification of HDFS part as soon as Common is committed (will cause HDFS builds to fail
until its respective part is committed)
- commit both at once (no problem is expected in this case)

I'd suggest to go with latter approach.


> Core doesn't have TestCommonCLI facility
> ----------------------------------------
>
>                 Key: HADOOP-6222
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6222
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>            Reporter: Boris Shkolnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6222.hdfs-part.patch, HADOOP-6222.hdfs-part.patch, HADOOP-6222.hdfs-part.patch,
HADOOP-6222.patch, HADOOP-6222.patch, HADOOP-6222.patch, HADOOP-6222.patch, HADOOP-6222.patch,
HADOOP-6222_hdfs_part.patch, HADOOP-6222_hdfs_part.patch
>
>
> TestCLI is a base class, which cannot run FS type of commands.
> We need a "copy" of TestHDFSCLI as TestCommonCLI to be able to test CLI stuff in common.
> I suggest we create TestCommonCLI.java in hadoop-common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message