hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Boris Shkolnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6222) Core doesn't have TestCommonCLI facility
Date Fri, 11 Dec 2009 01:01:21 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789057#action_12789057
] 

Boris Shkolnik commented on HADOOP-6222:
----------------------------------------

HADOOP-6222.patch
1. patch file names start with ../common/src, and it should start with src
2. don't we need at least one test in common to test this?

HADOOP-6222.hdfs-part.patch
1. Nit. no new line at the end of CMDFactoryDFS.java
2. in testStorageRestore - assert<False,True> calls should have different messages for
different cases. Right now they all say "after check call"....
3.Nit. TestHDFSCli has unremoved comment in execute() method.

> Core doesn't have TestCommonCLI facility
> ----------------------------------------
>
>                 Key: HADOOP-6222
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6222
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>            Reporter: Boris Shkolnik
>            Assignee: Konstantin Boudnik
>         Attachments: HADOOP-6222.hdfs-part.patch, HADOOP-6222.hdfs-part.patch, HADOOP-6222.patch,
HADOOP-6222.patch, HADOOP-6222.patch, HADOOP-6222.patch, HADOOP-6222_hdfs_part.patch, HADOOP-6222_hdfs_part.patch
>
>
> TestCLI is a base class, which cannot run FS type of commands.
> We need a "copy" of TestHDFSCLI as TestCommonCLI to be able to test CLI stuff in common.
> I suggest we create TestCommonCLI.java in hadoop-common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message