Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 32462 invoked from network); 13 Nov 2009 16:16:03 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 13 Nov 2009 16:16:03 -0000 Received: (qmail 64138 invoked by uid 500); 13 Nov 2009 16:16:02 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 64096 invoked by uid 500); 13 Nov 2009 16:16:02 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 63914 invoked by uid 99); 13 Nov 2009 16:16:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Nov 2009 16:16:02 +0000 X-ASF-Spam-Status: No, hits=-10.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Nov 2009 16:15:59 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 8E748234C1EF for ; Fri, 13 Nov 2009 08:15:39 -0800 (PST) Message-ID: <754853807.1258128939578.JavaMail.jira@brutus> Date: Fri, 13 Nov 2009 16:15:39 +0000 (UTC) From: "Andrzej Bialecki (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Updated: (HADOOP-6372) MurmurHash does not yield the same results as the reference C++ implementation when size % 4 >= 2 In-Reply-To: <1460990402.1258114539644.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated HADOOP-6372: -------------------------------------- Attachment: murmur.patch This patch includes the fix from Olivier, and updates the hash to Murmur 2.0A that provides better handling of empty keys. > MurmurHash does not yield the same results as the reference C++ implementation when size % 4 >= 2 > ------------------------------------------------------------------------------------------------- > > Key: HADOOP-6372 > URL: https://issues.apache.org/jira/browse/HADOOP-6372 > Project: Hadoop Common > Issue Type: Bug > Components: util > Affects Versions: 0.20.1 > Reporter: olivier gillet > Priority: Trivial > Attachments: HADOOP-6372.patch, murmur.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > Last rounds of MurmurHash are done in reverse order. data[length - 3], data[length - 2] and data[length - 1] in the block processing the remaining bytes should be data[len_m +2], data[len_m + 1], data[len_m]. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.