Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Message-ID: <1925866575.1258358680617.JavaMail.jira@brutus>
Date: Mon, 16 Nov 2009 08:04:40 +0000 (UTC)
From: "Vinod K V (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-6346) Add support for specifying unpack
 pattern regex to RunJar.unJar
In-Reply-To: <511668802.1256857199418.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778245#action_12778245 ] 

Vinod K V commented on HADOOP-6346:
-----------------------------------

Patch looks mostly good. Two comments:
 - Shouldn't we use the same pattern for RunJar to decide which classes it puts on its own classpath?
 - Add a test in TestRunJar to test particularly this feature? That it only unjars what is specified and leaves everything else jarred?

> Add support for specifying unpack pattern regex to RunJar.unJar
> ---------------------------------------------------------------
>
>                 Key: HADOOP-6346
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6346
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: conf, util
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hadoop-6346.txt, hadoop-6346.txt
>
>
> The changes in Common necessary for MAPREDUCE-967:
> - Adds support for Pattern types to Configuration (plus unit test)
> - Adds support to specify a Pattern to RunJar.unJar to decide which files get unpacked

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.