Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 58383 invoked from network); 2 Nov 2009 19:13:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 2 Nov 2009 19:13:23 -0000 Received: (qmail 35590 invoked by uid 500); 2 Nov 2009 19:13:23 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 35528 invoked by uid 500); 2 Nov 2009 19:13:22 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 35518 invoked by uid 99); 2 Nov 2009 19:13:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Nov 2009 19:13:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Nov 2009 19:13:20 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 63B57234C052 for ; Mon, 2 Nov 2009 11:12:59 -0800 (PST) Message-ID: <1116522474.1257189179393.JavaMail.jira@brutus> Date: Mon, 2 Nov 2009 19:12:59 +0000 (UTC) From: "Todd Lipcon (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Commented: (HADOOP-6269) Missing synchronization for defaultResources in Configuration.addResource In-Reply-To: <88262705.1253228937996.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-6269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772607#action_12772607 ] Todd Lipcon commented on HADOOP-6269: ------------------------------------- New patch looks good to me. +1 for the simpler approach > Missing synchronization for defaultResources in Configuration.addResource > ------------------------------------------------------------------------- > > Key: HADOOP-6269 > URL: https://issues.apache.org/jira/browse/HADOOP-6269 > Project: Hadoop Common > Issue Type: Bug > Components: conf > Affects Versions: 0.20.1 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Fix For: 0.20.2, 0.21.0 > > Attachments: HADOOP-6269-1.patch, HADOOP-6269-2.patch, hadoop-6269.txt, hadoop-6269.txt > > > Configuration.defaultResources is a simple ArrayList. In two places in Configuration it is accessed without appropriate synchronization, which we've seen to occasionally result in ConcurrentModificationExceptions. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.