hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar
Date Tue, 17 Nov 2009 03:21:39 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778702#action_12778702
] 

Todd Lipcon commented on HADOOP-6346:
-------------------------------------

bq. Shouldn't we use the same pattern for RunJar to decide which classes it puts on its own
classpath?
Are you suggesting opening up the jar with a new JarFile instance inside RunJar.main, and
then using the pattern to determine what strings to put on classpath? That seems not-quite-right
to me, since we want to unjar classes/**/*.class, but only added classes/ to the classpath,
right?

bq. Add a test in TestRunJar to test particularly this feature? That it only unjars what is
specified and leaves everything else jarred?
What jar should I use to test this with? There are not currently any jars generated in the
build/test directory. I could either (a) add a new ant target to generate a test.jar with
some files in it, or (b) generate the test jar from within the test case using JarOutputStream.
Any preference which I do?

> Add support for specifying unpack pattern regex to RunJar.unJar
> ---------------------------------------------------------------
>
>                 Key: HADOOP-6346
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6346
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: conf, util
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hadoop-6346.txt, hadoop-6346.txt
>
>
> The changes in Common necessary for MAPREDUCE-967:
> - Adds support for Pattern types to Configuration (plus unit test)
> - Adds support to specify a Pattern to RunJar.unJar to decide which files get unpacked

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message