hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6381) WritableUtils::*VLong utilities should be available for byte arrays
Date Wed, 18 Nov 2009 05:32:39 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779304#action_12779304
] 

Todd Lipcon commented on HADOOP-6381:
-------------------------------------

Hey Chris. I thought about this a bit more on the train (I'm an odd guy, I know) and realized
another similar issue: the decodeVint methods only return the integer and not the length consumed,
so again they're less than useful in a lot of circumstances. Namely, I'd imagine these sorts
of routines would be most handy when writing RawComparators where you might see a vint length
followed by a string. Without knowing how long the vint was, you can't really know where the
string starts.

Since Java sadly doesn't have tuples, I don't have a great idea what to do about this. Option
1 is to just leave it like you've got it. Option 2 would be to make the decode routines be
non-static methods of VIntWritable/VLongWritable. Any thoughts about this? I'm just hesitant
to add these public-facing APIs if we know them to be faulty and don't have a use case yet.

> WritableUtils::*VLong utilities should be available for byte arrays
> -------------------------------------------------------------------
>
>                 Key: HADOOP-6381
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6381
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: C6381-0.patch, C6381-1.patch, C6381-2.patch
>
>
> Particularly when working with raw bytes in Writables, it is often useful to have versions
of the vint utility functions for byte arrays.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message