Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 33864 invoked from network); 15 Oct 2009 08:48:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Oct 2009 08:48:54 -0000 Received: (qmail 37705 invoked by uid 500); 15 Oct 2009 08:48:54 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 37648 invoked by uid 500); 15 Oct 2009 08:48:54 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 37567 invoked by uid 99); 15 Oct 2009 08:48:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Oct 2009 08:48:54 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Oct 2009 08:48:52 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 5A31E234C1EE for ; Thu, 15 Oct 2009 01:48:31 -0700 (PDT) Message-ID: <527991595.1255596511368.JavaMail.jira@brutus> Date: Thu, 15 Oct 2009 01:48:31 -0700 (PDT) From: "Sreekanth Ramakrishnan (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Commented: (HADOOP-6269) Missing synchronization for defaultResources in Configuration.addResource In-Reply-To: <88262705.1253228937996.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-6269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765978#action_12765978 ] Sreekanth Ramakrishnan commented on HADOOP-6269: ------------------------------------------------ True, it was just a suggestion that if we can avoid class level locking it is better to do or remove synchronization fully. If we use one of concurrent data structures in java, we can avoid class level locking or any kind of locking right? > Missing synchronization for defaultResources in Configuration.addResource > ------------------------------------------------------------------------- > > Key: HADOOP-6269 > URL: https://issues.apache.org/jira/browse/HADOOP-6269 > Project: Hadoop Common > Issue Type: Bug > Components: conf > Affects Versions: 0.20.1 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Fix For: 0.20.2, 0.21.0 > > Attachments: hadoop-6269.txt, hadoop-6269.txt > > > Configuration.defaultResources is a simple ArrayList. In two places in Configuration it is accessed without appropriate synchronization, which we've seen to occasionally result in ConcurrentModificationExceptions. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.