Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 25585 invoked from network); 27 Oct 2009 22:56:02 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 27 Oct 2009 22:56:02 -0000 Received: (qmail 51368 invoked by uid 500); 27 Oct 2009 22:29:22 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 51303 invoked by uid 500); 27 Oct 2009 22:29:22 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 51289 invoked by uid 99); 27 Oct 2009 22:29:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2009 22:29:22 +0000 X-ASF-Spam-Status: No, hits=-10.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2009 22:29:19 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 615AF234C045 for ; Tue, 27 Oct 2009 15:28:59 -0700 (PDT) Message-ID: <1754088400.1256682539383.JavaMail.jira@brutus> Date: Tue, 27 Oct 2009 22:28:59 +0000 (UTC) From: "Hadoop QA (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Commented: (HADOOP-6317) Serialize the 'final'ness of Configuration keys In-Reply-To: <985698151.1255715791730.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-6317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770681#action_12770681 ] Hadoop QA commented on HADOOP-6317: ----------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423366/HADOOP-6317.4.patch against trunk revision 829289. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/106/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/106/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/106/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/106/console This message is automatically generated. > Serialize the 'final'ness of Configuration keys > ----------------------------------------------- > > Key: HADOOP-6317 > URL: https://issues.apache.org/jira/browse/HADOOP-6317 > Project: Hadoop Common > Issue Type: Improvement > Components: conf > Reporter: Arun C Murthy > Assignee: Aaron Kimball > Fix For: 0.22.0 > > Attachments: HADOOP-6317.2.patch, HADOOP-6317.3.patch, HADOOP-6317.4.patch, HADOOP-6317.patch > > > Currently Configuration.writeXml doesn't serialize the 'final' attribute. There are some scenarios where it is useful: > # TaskTracker should mark the tasks' 'localized' parameters as 'final' > # GUI tools -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.