Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 96959 invoked from network); 27 Oct 2009 23:51:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 27 Oct 2009 23:51:22 -0000 Received: (qmail 63994 invoked by uid 500); 27 Oct 2009 23:51:22 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 63931 invoked by uid 500); 27 Oct 2009 23:51:22 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 63912 invoked by uid 99); 27 Oct 2009 23:51:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2009 23:51:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2009 23:51:20 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 62F91234C045 for ; Tue, 27 Oct 2009 16:50:59 -0700 (PDT) Message-ID: <1637555915.1256687459394.JavaMail.jira@brutus> Date: Tue, 27 Oct 2009 23:50:59 +0000 (UTC) From: "Jakob Homan (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Updated: (HADOOP-6337) Update FilterInitializer class to be more visible and take a conf for further development In-Reply-To: <259446437.1256683739498.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated HADOOP-6337: -------------------------------- Attachment: HADOOP-6337.patch Patch with changes: * Update FilterInitializer class * Update test cases that test FilterInitializer * Update where filters are initialized in http server. No new tests as very difficult to test these changes. Manually verified that can now create a FilterInitializer in another package and that the new param is seen. > Update FilterInitializer class to be more visible and take a conf for further development > ----------------------------------------------------------------------------------------- > > Key: HADOOP-6337 > URL: https://issues.apache.org/jira/browse/HADOOP-6337 > Project: Hadoop Common > Issue Type: New Feature > Reporter: Jakob Homan > Assignee: Jakob Homan > Fix For: 0.22.0 > > Attachments: HADOOP-6337.patch > > > Currently the FilterInitializer class, used to filter access to the Hadoop web interfaces, has its main method, initFilter, set to package private. This means that any classes wishing to implement this type must be in the same package. This should be public so FilterInitializers can reside in other packages. > Also, currently all parameters to the FilterInitializer must be provided at compile time (or via a different configuration method). It would be better if the FilterInitalizer::initFilter received a Configuration parameter so it can pull conf values out at run-time. Alternatively, the class could implement Configured, but that seems heavier than is needed at this point. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.