hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6337) Update FilterInitializer class to be more visible and take a conf for further development
Date Wed, 28 Oct 2009 00:18:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770718#action_12770718
] 

Hadoop QA commented on HADOOP-6337:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12423376/HADOOP-6337.patch
  against trunk revision 829289.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/console

This message is automatically generated.

> Update FilterInitializer class to be more visible and take a conf for further development
> -----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6337
>             Project: Hadoop Common
>          Issue Type: New Feature
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6337.patch
>
>
> Currently the FilterInitializer class, used to filter access to the Hadoop web interfaces,
has its main method, initFilter, set to package private.  This means that any classes wishing
to implement this type must be in the same package.  This should be public so FilterInitializers
can reside in other packages.  
> Also, currently all parameters to the FilterInitializer must be provided at compile time
(or via a different configuration method).  It would be better if the FilterInitalizer::initFilter
received a Configuration parameter so it can pull conf values out at run-time.  Alternatively,
the class could implement Configured, but that seems heavier than is needed at this point.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message