hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sreekanth Ramakrishnan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6269) Missing synchronization for defaultResources in Configuration.addResource
Date Thu, 15 Oct 2009 06:43:31 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765936#action_12765936

Sreekanth Ramakrishnan commented on HADOOP-6269:

Took a look at the patch. 
* Can we avoid taking a lock at Class level instead do it at much finer level i.e. taking
a lock at {{defaultResources}} and acquire lock only on it?
* Or isn't better to directly use {{java.util.concurrent.CopyOnWriteArrayList}} here? It does
same thing which is being done in patch without synchronization?

> Missing synchronization for defaultResources in Configuration.addResource
> -------------------------------------------------------------------------
>                 Key: HADOOP-6269
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6269
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.20.1
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.20.2, 0.21.0
>         Attachments: hadoop-6269.txt, hadoop-6269.txt
> Configuration.defaultResources is a simple ArrayList. In two places in Configuration
it is accessed without appropriate synchronization, which we've seen to occasionally result
in ConcurrentModificationExceptions.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message