hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-6344) rm and rmr fail to correctly move the user's files to the trash prior to deleting when they are over quota.
Date Thu, 29 Oct 2009 22:37:59 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jakob Homan updated HADOOP-6344:
--------------------------------

    Attachment: HDFS-740.patch
                HDFS-740-for-Y20.patch

Attaching patches to fix this code path for trunk and Yahoo! 20 branch.  The problem is as
described, rather than stopping the delete, we swallow the exception and proceed.  These patches
fix that and toss the exception received from mkdirs up to FsShell.  After patch, the file
is not remains, the user is notified of the exception and the exception is logged.

Ran tests (all fine) and test-patch on trunk version: 
{noformat}[exec] +1 overall.  
[exec] 
[exec]     +1 @author.  The patch does not contain any @author tags.
[exec] 
[exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
[exec]                         Please justify why no new tests are needed for this patch.
[exec]                         Also please list what manual steps were performed to verify
this patch.
[exec] 
[exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
[exec] 
[exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
[exec] 
[exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
[exec] 
[exec]     +1 release audit.  The applied patch does not increase the total number of release
audit warnings.{noformat}
Tests and test-patch for Y! 20 release still pending.  Will update.

Reason for no tests: This is very difficult code path to test and we're doing it manually.
 This entire method should be refactored: there are like 10 different ways to get out of the
method and its tests re-written, since this has been the source of several bugs.  I'll open
a JIRA shortly to do this.  For now, I believe a manual test will suffice and drive the next
set of automatic tests.


> rm and rmr fail to correctly move the user's files to the trash prior to deleting when
they are over quota.  
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6344
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6344
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.20.0, 0.20.1, 0.21.0, 0.22.0
>            Reporter: gary murry
>         Attachments: HDFS-740-for-Y20.patch, HDFS-740.patch
>
>
> With trash turned on, if a user is over his quota and does a rm (or rmr), the file is
deleted without a copy being placed in the trash.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message