hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Kimball (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-5901) FileSystem.fixName() has unexpected behaviour
Date Fri, 23 Oct 2009 00:21:59 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Aaron Kimball updated HADOOP-5901:
----------------------------------

    Attachment: HADOOP-5901.patch

Attaching a patch which removes {{fixName}} and adds {{checkName}} in its place. Added unit
tests that check a variety of potential default fs URLs and make sure that {{FileSystem.get()}}
still returns something reasonable (e.g., the FileSystem associated with the {{DEFAULT_FS}}
URI).

The aforementioned stack overflow is prevented by this patch.

Locally, I get the following from test-patch:
{code}
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
{code}

> FileSystem.fixName() has unexpected behaviour
> ---------------------------------------------
>
>                 Key: HADOOP-5901
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5901
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.21.0
>            Reporter: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-5901.patch
>
>
> {{FileSystem.fixName()}} tries to patch up fs.default.name values, but I'm not sure it
helps that well. 
> Has it been warning about deprecated values for long enough for it to be turned off?


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message