hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-5901) FileSystem.fixName() has unexpected behaviour
Date Sat, 24 Oct 2009 02:04:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-5901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769571#action_12769571
] 

Konstantin Shvachko commented on HADOOP-5901:
---------------------------------------------

# In {{setDefaultURI()}} you catch an IOException and throw the IllegalArgumentException instead.
We shouldn't be throwing RunTimeExceptions from the code because this means a bug in the code
itself. Here you want to report a bad configuration parameter. Therefore, you should just
let the IOException flow up. Especially if in your case the IOExceptions contain more information
than mere "Invalid uri in setDefaultUri()".
# {{checkName()}} should be declared void.
# Also in {{checkName()}} the {{else{...}}} part can be dropped, I mean not the internals
but the enclosing brackets. This is a style thing, but simplifies code imho.
# I really liked a bunch of new tests for the file system parameter. Please check if you need
to close all successfully opened file systems.

> FileSystem.fixName() has unexpected behaviour
> ---------------------------------------------
>
>                 Key: HADOOP-5901
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5901
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.21.0
>            Reporter: Steve Loughran
>            Assignee: Aaron Kimball
>            Priority: Minor
>         Attachments: HADOOP-5901.patch
>
>
> {{FileSystem.fixName()}} tries to patch up fs.default.name values, but I'm not sure it
helps that well. 
> Has it been warning about deprecated values for long enough for it to be turned off?


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message