Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 74406 invoked from network); 14 Sep 2009 00:09:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 14 Sep 2009 00:09:21 -0000 Received: (qmail 78284 invoked by uid 500); 14 Sep 2009 00:09:21 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 78218 invoked by uid 500); 14 Sep 2009 00:09:21 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 78208 invoked by uid 99); 14 Sep 2009 00:09:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Sep 2009 00:09:21 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Sep 2009 00:09:18 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 9454F234C045 for ; Sun, 13 Sep 2009 17:08:57 -0700 (PDT) Message-ID: <956268448.1252886937593.JavaMail.jira@brutus> Date: Sun, 13 Sep 2009 17:08:57 -0700 (PDT) From: "Chris Douglas (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Updated: (HADOOP-5879) GzipCodec should read compression level etc from configuration MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Douglas updated HADOOP-5879: ---------------------------------- Attachment: H5879-5.patch * Merged with trunk * Calls end() in reinit, avoiding leak * Removes construct and resetStrategyAndCompressionLevel, which caused findbugs warnings. Relies on invariant windowBits set in cstr for Default/ZlibCompressors to avoid reemergence of HADOOP-5281 * Updated unit test to verify that compression level is reset > GzipCodec should read compression level etc from configuration > -------------------------------------------------------------- > > Key: HADOOP-5879 > URL: https://issues.apache.org/jira/browse/HADOOP-5879 > Project: Hadoop Common > Issue Type: Improvement > Components: io > Reporter: Zheng Shao > Assignee: He Yongqiang > Attachments: H5879-5.patch, hadoop-5879-5-21.patch, hadoop-5879-7-13-2.patch, hadoop-5879-7-13-3.patch, hadoop-5879-7-18-3.patch, hadoop-5879-7-26.patch > > > GzipCodec currently uses the default compression level. We should allow overriding the default value from Configuration. > {code} > static final class GzipZlibCompressor extends ZlibCompressor { > public GzipZlibCompressor() { > super(ZlibCompressor.CompressionLevel.DEFAULT_COMPRESSION, > ZlibCompressor.CompressionStrategy.DEFAULT_STRATEGY, > ZlibCompressor.CompressionHeader.GZIP_FORMAT, 64*1024); > } > } > {code} -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.