Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 70930 invoked from network); 28 Sep 2009 14:23:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 28 Sep 2009 14:23:38 -0000 Received: (qmail 4016 invoked by uid 500); 28 Sep 2009 14:23:38 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 3964 invoked by uid 500); 28 Sep 2009 14:23:38 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 3953 invoked by uid 99); 28 Sep 2009 14:23:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Sep 2009 14:23:37 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Sep 2009 14:23:36 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 44BCE234C004 for ; Mon, 28 Sep 2009 07:23:16 -0700 (PDT) Message-ID: <497521249.1254147796268.JavaMail.jira@brutus> Date: Mon, 28 Sep 2009 07:23:16 -0700 (PDT) From: "Arun C Murthy (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Commented: (HADOOP-6287) Support units for configuration knobs In-Reply-To: <2134744549.1254026236040.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760258#action_12760258 ] Arun C Murthy commented on HADOOP-6287: --------------------------------------- Eli, thanks for the patch, but I concur with Steve... I don't think we want to support units for Configuration.get{Int|Long}. I was planning on the lines of adding a new method: {code} Configuration.getStorage(String key, Unit unit); {code} where {code} enum Unit { B, KB, MB, GB, TB, PB, ... } {code} Thus, if we are setting ulimit we can do: {code}Configuration.getStorage("mapreduce.map.child.ulimit", KB);{code} File i/o buffer sizes: {code}Configuration.getStorage("io.file.buffer.size", KB);{code} Memory limits for child jvms: {code}Configuration.getStorage("mapreduce.job.map.memory", MB);{code} Thoughts? > Support units for configuration knobs > ------------------------------------- > > Key: HADOOP-6287 > URL: https://issues.apache.org/jira/browse/HADOOP-6287 > Project: Hadoop Common > Issue Type: Improvement > Components: conf > Reporter: Arun C Murthy > Assignee: Eli Collins > Attachments: hadoop-6287-1.patch > > > We should add support for units in our Configuration system so that we can specify values to be *1GB* or *1MB* rather than forcing every component which consumes such values to be aware of these. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.