hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Massie (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1
Date Fri, 04 Sep 2009 07:02:57 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751335#action_12751335
] 

Matt Massie commented on HADOOP-4675:
-------------------------------------

@stack: the patch compiles if you run, e.g...

{code}
CLASSPATH="../hadoop-hdfs/build/hadoop-hdfs-0.21.0-dev.jar:../hadoop-hdfs/build/hadoop-hdfs-test-0.21.0-dev.jar"
ant bin-package
{code}
You're correct that MiniDFSCluster is not a part of hadoop-common but rather hadoop-hdfs.

In the future, I will run something like the following to test patches since I think it closely
mimics Hudson, e.g.

{code}
ant test-patch -Dpatch.file=HADOOP-4675-v9.patch  -Dfindbugs.home=... -Djava5.home=... -Dforrest.home=...
{code}

where none of the non-hadoop-common jars are in the classpath. 

I read through your test and agree: it is creative.  It's a shame that MiniDFSCluster isn't
available in common.  Maybe the test should be commented out until Mini clusters are available
for common tests?  It's not ideal but having this patch linger on without resolution isn't
ideal either.  The code in the patch shouldn't be prone to bugs since it's simply sending
specially crafted UDP messages.  I trust that Java sockets have been thoroughly tested and
the xdr_ functions are very straight-forward (e.g. xdr_int is basically htonl()).

Btw, your approach to sending the ganglia meta data each time is practical.  It can be optimized
in the future but that might add unwelcome complexity.



> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.21.0
>            Reporter: Brian Bockelman
>            Assignee: Brian Bockelman
>             Fix For: 0.21.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch,
HADOOP-4675-v6.patch, HADOOP-4675-v7.patch, HADOOP-4675-v8.patch, HADOOP-4675-v9.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only
works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message