hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6278) Update HowToCommit with clear list of Committer responsibilities
Date Tue, 22 Sep 2009 22:55:16 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758467#action_12758467
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-6278:
------------------------------------------------

Sounds great!   Some questions:

> 1) For non-trivial patches, code reviews must be done by another committer.

Does it mean that non-committers can review trivial patches?  Then, does a committer require
to review the trivial patch when committing it?

BTW, it may be hard to decide whether a patch is trivial or not.

> 5) A -1 from Hadoop QA for core and contrib unit tests means the patch must not be committed
until these are fixed (else every subsequent patch will get -1 on these)

What if an existing unit test fails, which is not related to the patch?  An example is TestBackupNode
(HDFS-192), which keeps failing in 6 months.

> Update HowToCommit with clear list of Committer responsibilities
> ----------------------------------------------------------------
>
>                 Key: HADOOP-6278
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6278
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: site
>            Reporter: Nigel Daley
>            Priority: Critical
>
> http://wiki.apache.org/hadoop/HowToCommit should be updated to clearly spell out these
committer responsibilities:
> 1) For non-trivial patches, code reviews must be done by another *committer*.
> 2) Code reviews follow the checklist (http://wiki.apache.org/hadoop/CodeReviewChecklist)
so that, among other things, the patch is checked for robust documentation and unit tests

> 3) A -1 from Hadoop QA for lack of unit tests *must* be explained satisfactorily by the
contributor else the patch *is not* committed. In this case, the manual tests performed by
the contributor must be explained.
> 4) A -1 from Hadoop QA for findbugs, javadoc, or javac warnings means the patch *must
not* be committed until these are fixed (else every subsequent patch will get -1 on these)
> 5) A -1 from Hadoop QA for core *and* contrib unit tests means the patch *must not* be
committed until these are fixed (else every subsequent patch will get -1 on these)
> Others responsibilities?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message