Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 50993 invoked from network); 26 Aug 2009 02:26:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 26 Aug 2009 02:26:56 -0000 Received: (qmail 41083 invoked by uid 500); 26 Aug 2009 02:27:21 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 41034 invoked by uid 500); 26 Aug 2009 02:27:21 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 41023 invoked by uid 99); 26 Aug 2009 02:27:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Aug 2009 02:27:21 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Aug 2009 02:27:20 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 44D76234C04C for ; Tue, 25 Aug 2009 19:26:59 -0700 (PDT) Message-ID: <1557437862.1251253619268.JavaMail.jira@brutus> Date: Tue, 25 Aug 2009 19:26:59 -0700 (PDT) From: "Konstantin Boudnik (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Updated: (HADOOP-6205) Project java code has a significant number of declaration javadoc warnings and errors In-Reply-To: <2108675829.1250797574846.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-6205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Boudnik updated HADOOP-6205: --------------------------------------- Attachment: Eclipse-JavaDoc-errors.png To reproduce the same situation in the Eclipse it needs to be configured as show in the attachment. These settings reveal 1000+ issues with missing tags or fields/parameters which can't be resolved. And this is for {{public}} methods only If missing tags might be considered as a warnings then unresolvable parameters have to be looked upon as errors and addressed accordingly. I can't find how to reproduce this analysis with JavaDoc+javac tools yet.. I'm going to attach the list of 'unresolved parameters' for future consideration. > Project java code has a significant number of declaration javadoc warnings and errors > ------------------------------------------------------------------------------------- > > Key: HADOOP-6205 > URL: https://issues.apache.org/jira/browse/HADOOP-6205 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Konstantin Boudnik > Assignee: Konstantin Boudnik > Attachments: Eclipse-JavaDoc-errors.png > > > The issue here is that code inspections (say by IntelliJ IDEA) show that a number of classes have javadoc problems in declarations. Some of those are minor, e.g. missing @return, @param, @throws tags. > Some of them are more severe, e.g. using non-existing parameter names in a method javadoc (see HDFS' BlockManager.removeFromInvalidates(..) for an example) > I'd like to add more sophisticated code analysis to be able to fix at least javadoc declaration errors in order to produce better code quality. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.