hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hemanth Yamijala (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4491) Per-job local data on the TaskTracker node should have right access-control
Date Tue, 04 Aug 2009 09:29:14 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738914#action_12738914

Hemanth Yamijala commented on HADOOP-4491:

This is looking much simpler and good. Some comments, mostly minor:

- When mapred.local.dir is changed in TaskRunner for sandboxing the child, it affects the
JobConf instance in the TaskInProgress. This seems error prone. Can we check if this can be
moved to the Child directly.
- Add a comment saying why permissions are being set for the job and task directories at localization
time itself, as opposed to inside the task-controller executable. This is mainly to narrow
down the possibility of misuse, until we do a change of the group ownership.
- In the same line, set permissions to tasklog attempt directory to restrictive permissions.
- Add a comment to explain that split.dta is only used in the case of IsolationRunner where
the changes are made in IsolationRunner.
- We are still passing the log directory to the task-controller - doesn't seem needed.
- I would suggest InitializeJobContext to be named as JobInitializationContext; doJobLocalization
to localizeJobFiles and likewise for tasks.

I have still to look at the task-controller changes, will take the latest patch for the same.

> Per-job local data on the TaskTracker node should have right access-control
> ---------------------------------------------------------------------------
>                 Key: HADOOP-4491
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4491
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>            Reporter: Arun C Murthy
>            Assignee: Vinod K V
>         Attachments: HADOOP-4491-20090623-common.1.txt, HADOOP-4491-20090623-mapred.1.txt,
HADOOP-4491-20090703-common.1.txt, HADOOP-4491-20090703-common.txt, HADOOP-4491-20090703.1.txt,
HADOOP-4491-20090703.txt, HADOOP-4491-20090707-common.txt, HADOOP-4491-20090707.txt, HADOOP-4491-20090716-mapred.txt,
HADOOP-4491-20090803.1.txt, HADOOP-4491-20090803.txt

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message