hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sreekanth Ramakrishnan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6184) Provide a configuration dump in json format.
Date Tue, 11 Aug 2009 03:54:15 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741679#action_12741679
] 

Sreekanth Ramakrishnan commented on HADOOP-6184:
------------------------------------------------

in writeJson

* reloadConfiguration() call is not required.
* Can we make the method a static method with signature as following public static void writeJson(Configuration
conf, Writer writer)
for(Map.Entry<Object,Object> item: getProps().entrySet()) { should be changed to  for(Map.Entry<Object,Object>
item: conf.getProps().entrySet()) { where conf is your local variable.
* uncomment the line dumpGenerator.flush(); while iterating over each key
* Please dont import like import org.codehaus.jackson.*; import specific classes and interfaces.
* Comments in testcase.

> Provide a configuration dump in json format.
> --------------------------------------------
>
>                 Key: HADOOP-6184
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6184
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: rahul k singh
>         Attachments: HADOOP-6184.patch
>
>
> Configuration dump in json format.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message