Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 19545 invoked from network); 20 Jul 2009 22:34:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 20 Jul 2009 22:34:32 -0000 Received: (qmail 61358 invoked by uid 500); 20 Jul 2009 22:35:37 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 61316 invoked by uid 500); 20 Jul 2009 22:35:37 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 61306 invoked by uid 99); 20 Jul 2009 22:35:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jul 2009 22:35:37 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jul 2009 22:35:35 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id CA23F234C044 for ; Mon, 20 Jul 2009 15:35:14 -0700 (PDT) Message-ID: <634330581.1248129314813.JavaMail.jira@brutus> Date: Mon, 20 Jul 2009 15:35:14 -0700 (PDT) From: "Raghu Angadi (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Commented: (HADOOP-6132) RPC client opens an extra connection for VersionedProtocol In-Reply-To: <840919907.1247085075163.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-6132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733381#action_12733381 ] Raghu Angadi commented on HADOOP-6132: -------------------------------------- sure. That is fine. If someone actually ends up using the interface, they will be similarly surprised. But for now I guess it is fine. If we want to fix it, we need to make the interface take class object as one of the arguments (since that is part of definition of what a connection is). +1. > RPC client opens an extra connection for VersionedProtocol > ---------------------------------------------------------- > > Key: HADOOP-6132 > URL: https://issues.apache.org/jira/browse/HADOOP-6132 > Project: Hadoop Common > Issue Type: Bug > Components: ipc > Reporter: Kan Zhang > Assignee: Kan Zhang > Attachments: 1.patch, 2.patch > > > RPC client caches connections per protocol. However, since all of our real protocols are subclasses of VersionedProtocol, a bug in the implementation makes the client opens an extra connection just for the VersionedProtocol, which is not needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.