hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mahadev konar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6131) A sysproperty should not be set unless the property is set on the ant command line in build.xml.
Date Wed, 08 Jul 2009 20:31:15 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728883#action_12728883
] 

Mahadev konar commented on HADOOP-6131:
---------------------------------------

+1 to the patch. the -1 from tests is because hudson is running create-c++-configure which
isnt a target in common. 
      
{code} [exec] /home/hudson/tools/ant/latest/bin/ant -Dversion=791937_HADOOP-6131_PATCH-12412848
-DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=/home/nigel/tools/forrest/latest
-Djava5.home=/home/hudson/tools/java/latest1.5 create-c++-configure test-core 
{code}

> A sysproperty should not be set unless the property is set on the ant command line in
build.xml.
> ------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6131
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6131
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Hong Tang
>            Assignee: Hong Tang
>            Priority: Trivial
>             Fix For: 0.21.0
>
>         Attachments: hadoop-6131.patch
>
>
> Patch for HADOOP-3315 contains an improper usage of setting a sysproperty. What it does
now:
> {code}
>       <sysproperty key="io.compression.codec.lzo.class"
>           value="${io.compression.codec.lzo.class}"/>
> {code}
> What should be:
> {code} 
>      <syspropertyset dynamic="no">
>          <propertyref name="io.compression.codec.lzo.class"/>
>       </syspropertyset>
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message