hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6132) RPC client opens an extra connection for VersionedProtocol
Date Fri, 10 Jul 2009 07:35:14 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729558#action_12729558
] 

Hadoop QA commented on HADOOP-6132:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12412921/2.patch
  against trunk revision 792812.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/561/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/561/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/561/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/561/console

This message is automatically generated.

> RPC client opens an extra connection for VersionedProtocol
> ----------------------------------------------------------
>
>                 Key: HADOOP-6132
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6132
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: 1.patch, 2.patch
>
>
> RPC client caches connections per protocol. However, since all of our real protocols
are subclasses of VersionedProtocol, a bug in the implementation makes the client opens an
extra connection just for the VersionedProtocol, which is not needed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message