From common-dev-return-101158-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Dec 13 19:10:17 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C9AAA180609 for ; Thu, 13 Dec 2018 19:10:16 +0100 (CET) Received: (qmail 41302 invoked by uid 500); 13 Dec 2018 18:10:13 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-dev@hadoop.apache.org Received: (qmail 41256 invoked by uid 99); 13 Dec 2018 18:10:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Dec 2018 18:10:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 11FDF180AC9; Thu, 13 Dec 2018 18:10:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.811 X-Spam-Level: * X-Spam-Status: No, score=1.811 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, T_MIXED_ES=0.01, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id xRhOEjMylWDM; Thu, 13 Dec 2018 18:10:09 +0000 (UTC) Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id D598D60D27; Thu, 13 Dec 2018 18:10:08 +0000 (UTC) Received: by mail-qt1-f179.google.com with SMTP id v11so3229745qtc.2; Thu, 13 Dec 2018 10:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Hc6ERQyick8hmLmSozQgSgRQqZD+rjCi91NXBoRNkhs=; b=vAdXvEQ9x/Un114Hc6QrP+AnVgjSGSJdGNfsJ3UwTc6uC+rGuwzO6LhHjzemjNsHYY nYFW0Qw+g3oOe+brxLkOQ+6Tu40AGAio5Ga8QXcyC4W3wj8KVBMObN16kqpDtGQAJjLv 684XZA40YoioWKIk+M06xgZDeAb5iHrdkxb4DwLxKHFhmml/IQv0dy7gkrHFpIDTwpUy X18sGs5NIE8qer5HsJXRxsFC5BkAjQ5iR21eeupsdrCLDahvG4DwfzJHnz719EMFmmR5 sbxzP6ylw/iFxDwd2mNOzC7gX9dP2FdUmx6Q4Oe24Hk1t8jJMZBdm2a2PquwG1oVvM7f XRpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hc6ERQyick8hmLmSozQgSgRQqZD+rjCi91NXBoRNkhs=; b=l8bR1TLJJmdRf10cLKsgkzy3Bs4AbtHiMPrCbxG/fBWX/IuO1F5otbbBePLZ4XP1Bk i9ifRL2JWxmhacPQwPE/PGuTFRgMJ9jp5YonFwLoZ3EDSzkD8Ti5fPeHZfvPQFSexUd6 jgnPyhnjVIbCWx2Vfgs83A8e69Ac3uIMFhRq+IG3baClNF8p84ogTSYM0gZHSGDXJVDB Y1SUQFXCWysT68LYxOgZkQ/nxzohTraHLP07czUbd43ukrvSyaA3k94prnVA/hmf78j8 vOOvy6n6v4EtK1AHv03pjgk8ZijxAKE62Ic25CVYdk+svsG8YrUQcOMI1QJStHvLHJi9 V/pQ== X-Gm-Message-State: AA+aEWYNZU/Du95chtR/QYHaZ7z9x5BRIANZ6lhiTxzakPTFNpLl611M S/CIzspEB2XCoHK1w1odR86N3xWIN4hUtquV5HQ= X-Google-Smtp-Source: AFSGD/UBPtSOOANSPfbWtWlQaRUR7T/y5380m2UTwdQwNxgw6ha2Bz1f6m3sqg9LEHbTeRwm0931HQnaDOWry2kLEoQ= X-Received: by 2002:aed:2844:: with SMTP id r62mr25427721qtd.112.1544724601939; Thu, 13 Dec 2018 10:10:01 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Konstantin Shvachko Date: Thu, 13 Dec 2018 10:09:50 -0800 Message-ID: Subject: [Result] [VOTE] Merge HDFS-12943 branch to trunk - Consistent Reads from Standby To: Daryn Sharp , hdfs-dev , Hadoop Common Cc: mapreduce-dev@hadoop.apache.org, yarn-dev@hadoop.apache.org Content-Type: multipart/alternative; boundary="0000000000002ca9dd057ceb3941" --0000000000002ca9dd057ceb3941 Content-Type: text/plain; charset="UTF-8" This vote failed due to Daryn Sharp's veto. The concern is being addressed by HDFS-13873. I will start a new vote once this is committed. Note for Daryn. Your non-responsive handling of the veto makes a bad precedence and is a bad example of communication on the lists from a respected member of this community. Please check your availability for followup discussions if you choose to get involved with important decisions. On Fri, Dec 7, 2018 at 4:10 PM Konstantin Shvachko wrote: > Hi Daryn, > > Wanted to backup Chen's earlier response to your concerns about rotating > calls in the call queue. > Our design > 1. targets directly the livelock problem by rejecting calls on the > Observer that are not likely to be responded in timely matter: HDFS-13873. > 2. The call queue rotation is only done on Observers, and never on the > active NN, so it stays free of attacks like you suggest. > > If this is a satisfactory mitigation for the problem could you please > reconsider your -1, so that people could continue voting on this thread. > > Thanks, > --Konst > > On Thu, Dec 6, 2018 at 10:38 AM Daryn Sharp wrote: > >> -1 pending additional info. After a cursory scan, I have serious >> concerns regarding the design. This seems like a feature that should have >> been purely implemented in hdfs w/o touching the common IPC layer. >> >> The biggest issue in the alignment context. It's purpose appears to be >> for allowing handlers to reinsert calls back into the call queue. That's >> completely unacceptable. A buggy or malicious client can easily cause >> livelock in the IPC layer with handlers only looping on calls that never >> satisfy the condition. Why is this not implemented via RetriableExceptions? >> >> On Thu, Dec 6, 2018 at 1:24 AM Yongjun Zhang >> wrote: >> >>> Great work guys. >>> >>> Wonder if we can elaborate what's impact of not having #2 fixed, and why >>> #2 >>> is not needed for the feature to complete? >>> 2. Need to fix automatic failover with ZKFC. Currently it does not >>> doesn't >>> know about ObserverNodes trying to convert them to SBNs. >>> >>> Thanks. >>> --Yongjun >>> >>> >>> On Wed, Dec 5, 2018 at 5:27 PM Konstantin Shvachko >> > >>> wrote: >>> >>> > Hi Hadoop developers, >>> > >>> > I would like to propose to merge to trunk the feature branch >>> HDFS-12943 for >>> > Consistent Reads from Standby Node. The feature is intended to scale >>> read >>> > RPC workloads. On large clusters reads comprise 95% of all RPCs to the >>> > NameNode. We should be able to accommodate higher overall RPC >>> workloads (up >>> > to 4x by some estimates) by adding multiple ObserverNodes. >>> > >>> > The main functionality has been implemented see sub-tasks of >>> HDFS-12943. >>> > We followed up with the test plan. Testing was done on two independent >>> > clusters (see HDFS-14058 and HDFS-14059) with security enabled. >>> > We ran standard HDFS commands, MR jobs, admin commands including manual >>> > failover. >>> > We know of one cluster running this feature in production. >>> > >>> > There are a few outstanding issues: >>> > 1. Need to provide proper documentation - a user guide for the new >>> feature >>> > 2. Need to fix automatic failover with ZKFC. Currently it does not >>> doesn't >>> > know about ObserverNodes trying to convert them to SBNs. >>> > 3. Scale testing and performance fine-tuning >>> > 4. As testing progresses, we continue fixing non-critical bugs like >>> > HDFS-14116. >>> > >>> > I attached a unified patch to the umbrella jira for the review and >>> Jenkins >>> > build. >>> > Please vote on this thread. The vote will run for 7 days until Wed Dec >>> 12. >>> > >>> > Thanks, >>> > --Konstantin >>> > >>> >> >> >> -- >> >> Daryn >> > --0000000000002ca9dd057ceb3941--