From common-dev-return-100359-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Aug 15 18:37:46 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6FF78180626 for ; Wed, 15 Aug 2018 18:37:46 +0200 (CEST) Received: (qmail 17666 invoked by uid 500); 15 Aug 2018 16:37:44 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-dev@hadoop.apache.org Received: (qmail 17644 invoked by uid 99); 15 Aug 2018 16:37:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Aug 2018 16:37:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4EE51CB06B; Wed, 15 Aug 2018 16:37:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.102 X-Spam-Level: X-Spam-Status: No, score=-0.102 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=effectivemachines.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id OPeN_1FTIH3k; Wed, 15 Aug 2018 16:37:42 +0000 (UTC) Received: from effectivemachines.com (effectivemachines.com [104.236.136.112]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id BD3B95F432; Wed, 15 Aug 2018 16:37:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by effectivemachines.com (Postfix) with ESMTP id 3F9CA1608AD; Wed, 15 Aug 2018 09:37:34 -0700 (PDT) Received: from effectivemachines.com ([127.0.0.1]) by localhost (effectivemachines.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id MaiuFcC4HEhK; Wed, 15 Aug 2018 09:37:34 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by effectivemachines.com (Postfix) with ESMTP id 04265161D6D; Wed, 15 Aug 2018 09:37:34 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 effectivemachines.com 04265161D6D X-Virus-Scanned: amavisd-new at effectivemachines.com Received: from effectivemachines.com ([127.0.0.1]) by localhost (effectivemachines.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BwbdqSkmxkDO; Wed, 15 Aug 2018 09:37:33 -0700 (PDT) Received: from [192.168.100.206] (108-193-1-249.lightspeed.sntcca.sbcglobal.net [108.193.1.249]) by effectivemachines.com (Postfix) with ESMTPSA id C7DC81608AD; Wed, 15 Aug 2018 09:37:33 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: Checkstyle shows false positive report From: Allen Wittenauer In-Reply-To: Date: Wed, 15 Aug 2018 09:37:33 -0700 Cc: Hadoop Common , Hdfs-dev Content-Transfer-Encoding: quoted-printable Message-Id: <0CFCF524-552C-4728-B676-B28B0804154A@effectivemachines.com> References: To: =?utf-8?B?S2l0dGkgTsOhbsOhc2k=?= X-Mailer: Apple Mail (2.3273) > On Aug 15, 2018, at 4:49 AM, Kitti N=C3=A1n=C3=A1si = wrote: >=20 > Hi All, >=20 > We noticed that the checkstyle run by the pre commit job started to = show > false positive reports, so I created HADOOP-15665 > . >=20 > Until that is fixed, keep in mind to run the checkstyle by your IDE > manually for the patches you upload or review. I=E2=80=99ve tracked it down to HDDS-119. I have no idea why = that JIRA Is changing the checkstyle suppressions file, since the asf = license check is it=E2=80=99s own thing and check style wouldn=E2=80=99t = be looking at those files anyway. That said, there is a bug in Yetus in that it should have = reported that checkstyle failed to run. I=E2=80=99ve filed YETUS-660 for = that.= --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-dev-help@hadoop.apache.org