Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: Same jenkins build running on 2 patches.
From: Allen Wittenauer <aw@effectivemachines.com>
In-Reply-To: <CAMqJVeOHrxE3N4mGNcRZqc_Hzcr5afPniwnmgMcjwzMkQ8Ye1w@mail.gmail.com>
Date: Sat, 2 Dec 2017 21:19:59 -0800
Cc: Rushabh Shah <rushabhs@oath.com>,
 Hadoop Common <common-dev@hadoop.apache.org>,
 aw@apache.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <FA6C1777-D9D7-4DF3-B12A-6F7701A0C030@effectivemachines.com>
References: <CAAvsqTqCdm=5ubvvrk7zfT9ZdyOSxzkqBnhTJL2EJbe0YghLSQ@mail.gmail.com>
 <E23AF590-EBE6-466D-8BBE-BD36CF6788AE@effectivemachines.com>
 <CAMqJVeOHrxE3N4mGNcRZqc_Hzcr5afPniwnmgMcjwzMkQ8Ye1w@mail.gmail.com>
To: Jason Lowe <jlowe@oath.com>
archived-at: Sun, 03 Dec 2017 05:20:14 -0000


> On Dec 1, 2017, at 1:36 PM, Jason Lowe <jlowe@oath.com> wrote:
>  I thought the admin precommit build was kicking off the =
project-specific precommit build with an attachment ID argument so the =
project precommit can be consistent with the admin precommit build on =
what triggered the precommit process.

	 precommit-admin generates a list of JIRA issue ids and passes =
those to the build jobs.  The JIRA issue ids are generated from a simple =
JQL statement.  precommit build is the first time the attachment id=E2=80=99=
s are determined.

> If the patch is tracked by attachment ID then I think the build would =
remain consistent even when users attach new patches in the middle of =
the precommit process.

	Implementation of YETUS-504 will almost certainly eliminate the =
double download in Dockerized situations since the credentials will only =
be available outside of it.  In the process, certain testing scenarios =
also get dropped, but security is more important.

	That said, fixing users attempting to prematurely optimize test =
runs is pretty low on the priority list.  For my own project list, some =
way to inform a user that only 20-30% of the HDFS unit tests in branch-2 =
are getting executed is way higher.  [trunk comes in at around 80% =
post-surefire 2.20.1.]  precommit=E2=80=99s output doesn=E2=80=99t =
reflect tests that don=E2=80=99t run because surefire doesn=E2=80=99t =
report them either. See also SUREFIRE-1447. =20


---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org