hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Subru Krishnan <su...@apache.org>
Subject Re: Cutting branch-2.9
Date Fri, 03 Nov 2017 23:30:51 GMT
Hello Junping

Thanks for taking the time/effort to go through this. Including our reply
so that folks in the list have the full context.

> 1. It looks like we change from log4j to sel4j (HADOOP-12956) in 2.9
which is a huge incompatible change. Do we have consensus on this in
community (as I saw HBase community are deny this kind of change in minor
release)? If so, we should document somewhere what is changed and what's
the impact.
As per the compatibility guidelines (http://hadoop.apache.org/
docs/current/hadoop-project-dist/hadoop-common/Compatibility.html#Log4j_
Configuration_Files), our understanding is that if SLF4j can read the old
Log4j property files, we should be good - and it is the case.

>  2. Some APIs (deprecated in 2.8) get removed. My understanding is we
only remove deprecated API in next major release (3.0) but not minor
release. Please double check this with some documents or other guys for
certain answer.
We see only 2 DEPRECATED methods have been removed:
- The AllocateResponse.newInstance method and the RMProxy<T>.createRMProxy
methods. Both are internal builders and are not really APIs IMHO - so we
feel this should not be a blocker.

>  3. Some stable APIs get removed, like: YarnScheduler.allocate(), etc. We
may need to add it back before we go for RC stage.
Are you sure you are running JACC against latest 2.8.2 artifacts - as we
saw a much smaller delta when we ran jdiff ? Case in point: Looks like the
YarnScheduler#allocate() changes were already part of 2.8.2 as per (
https://github.com/apache/hadoop/blob/branch-2.8.2/
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-
resourcemanager/src/main/java/org/apache/hadoop/yarn/server/
resourcemanager/scheduler/YarnScheduler.java) and the relevant JIRA is
YARN-5221.

-Subru/Arun

On Fri, Nov 3, 2017 at 4:24 PM, Junping Du <jdu@hortonworks.com> wrote:

> Below is some findings from my recently run of JACC (
> https://builds.apache.org/job/Hadoop-2.9-JACC/12/
> artifact/target/compat-check/report.html) job against 2.9 and 2.8.2. I
> have discussed with Arun and Subru offline on jdiff report who convinced me
> some of items are not a big concern. Just tried to list here in case people
> in community have different voices:
>
>  My original concerns of incompatibilities:
>      1. It looks like we change from log4j to sel4j (HADOOP-12956) in 2.9
> which is a huge incompatible change. Do we have consensus on this in
> community - as I saw HBase community are deny this kind of change in minor
> release? I talked with several other guys who seems to have different
> opinion.
>
>     2. Some APIs (deprecated in 2.8) get removed. My understanding is we
> only remove deprecated API in next major release (3.0) but not minor
> release. - Arun and Subru convinced me that removed 2 methods are not
> supposed to be used by other downstream projects
>
>     3. Some stable APIs get removed, like: YarnScheduler.allocate(), etc.
> We may need to add it back for compatibility of Scheduler API.
>
> Thoughts?
>
> Thanks,
>
> Junping
>
> ________________________________________
> From: Arun Suresh <asuresh@apache.org>
> Sent: Thursday, November 2, 2017 11:55 PM
> To: 俊平堵
> Cc: Arun Suresh; subru@apache.org; common-dev@hadoop.apache.org;
> yarn-dev@hadoop.apache.org; hdfs-dev@hadoop.apache.org;
> mapreduce-dev@hadoop.apache.org
> Subject: Re: Cutting branch-2.9
>
> Quick update folks.
>
> We just cut branch-2.9.0, and set the mvn version to 2.9.0
> We've also updated the version on branch-2.9 to 2.9.1-SNAPSHOT.
>
> Expect an RC in the next 24 hrs :)
>
> Cheers
> -Arun/Subru
>
> On Tue, Oct 31, 2017 at 5:24 PM, Arun Suresh <arun.suresh@gmail.com>
> wrote:
>
> > Hi Junping,
> >
> > > In the mean time, branch-2.9 should be reserved for next 2.9 point
> > release (2.9.1) and branch-2 should be reserved for next minor release
> > (2.10.0 or whatever name it is). Thoughts?
> > Yup, That is the current plan. We've updated mvn versions in branch-2 to
> > point to 2.10.0-SNAPSHOT.
> > Once we cut branch-2.9.0, we will update mvn versions on branch-2.9.0 to
> > 2.9.0 and set versions on branch-2.9 to 2.9.1-SNAPSHOT (We plan to do
> that
> > by Thursday)
> >
> > Cheers
> > -Arun
> >
> > On Tue, Oct 31, 2017 at 2:35 PM, 俊平堵 <dujunping@gmail.com> wrote:
> >
> >> Hi Arun/Subru,
> >>     Thanks for updating on 2.9.0 release progress. A quick question
> here:
> >> are we planning to release from branch-2.9 directly?
> >>     I doubt this as it seems against our current branch release
> practice (
> >> https://wiki.apache.org/hadoop/HowToRelease#Branching). To get rid of
> >> any confusion, I would suggest to cut-off branch-2.9.0 for 2.9.0 release
> >> work. In the mean time, branch-2.9 should be reserved for next 2.9 point
> >> release (2.9.1) and branch-2 should be reserved for next minor release
> >> (2.10.0 or whatever name it is). Thoughts?
> >>
> >> bq. @Junping, lets move the jdiff conversation to separate thread.
> >> Sure. I will reply jdiff in separated thread.
> >>
> >> Thanks,
> >>
> >> Junping
> >>
> >> 2017-10-31 13:44 GMT-07:00 Arun Suresh <asuresh@apache.org>:
> >>
> >>> Hello folks
> >>>
> >>> We just cut branch-2.9 since all the critical/blocker issues are now
> >>> resolved.
> >>> We plan to perform some sanity checks for the rest of the week and cut
> >>> branch-2.9.0 and push out an RC0 by the end of the week.
> >>>
> >>> Kindly refrain from committing to branch-2.9 without giving us a heads
> >>> up.
> >>>
> >>> @Junping, lets move the jdiff conversation to separate thread.
> >>>
> >>> Cheers
> >>> -Arun/Subru
> >>>
> >>> On Mon, Oct 30, 2017 at 12:39 PM, Subru Krishnan <subru@apache.org>
> >>> wrote:
> >>>
> >>> > We want to give heads up that we are going to cut branch-2.9 tomorrow
> >>> > morning.
> >>> >
> >>> > We are down to 3 blockers and they all are close to being committed
> >>> > (thanks everyone):
> >>> > https://cwiki.apache.org/confluence/display/HADOOP/
> Hadoop+2.9+Release
> >>> >
> >>> > There are 4 other non-blocker JIRAs that are targeted for 2.9.0 which
> >>> are
> >>> > close to completion.
> >>> >
> >>> > Folks who are working/reviewing these, kindly prioritize accordingly
> so
> >>> > that we can make the release on time.
> >>> > https://issues.apache.org/jira/browse/YARN-7398?filter=12342468
> >>> >
> >>> > Thanks in advance!
> >>> >
> >>> > -Subru/Arun
> >>> >
> >>> >
> >>> >
> >>>
> >>
> >>
> >
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message