hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Zhuge (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (HADOOP-14954) MetricsSystemImpl#init should increment refCount when already initialized
Date Mon, 23 Oct 2017 22:37:00 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-14954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

John Zhuge reopened HADOOP-14954:
---------------------------------

Reverted because it broke a bunch of YARN tests, e.g., TestContainerAllocation.

> MetricsSystemImpl#init should increment refCount when already initialized
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-14954
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14954
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 2.7.0
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Minor
>         Attachments: HADOOP-14954.001.patch, HADOOP-14954.002.patch, HADOOP-14954.002a.patch
>
>
> {{++refCount}} here in {{init}} should be symmetric to {{--refCount}} in {{shutdown}}.
> {code:java}
>   public synchronized MetricsSystem init(String prefix) {
>     if (monitoring && !DefaultMetricsSystem.inMiniClusterMode()) {
>       LOG.warn(this.prefix +" metrics system already initialized!");
>       return this;
>     }
>     this.prefix = checkNotNull(prefix, "prefix");
>     ++refCount;
> {code}
> Move {{++refCount}}  to the beginning of this method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org


Mime
View raw message