Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 21 Jun 2017 14:18:00 +0000 (UTC)
From: "Rushabh S Shah (JIRA)" <jira@apache.org>
To: common-dev@hadoop.apache.org
Message-ID: <JIRA.13081437.1498054652000.70343.1498054680255@Atlassian.JIRA>
In-Reply-To: <JIRA.13081437.1498054652000@Atlassian.JIRA>
References: <JIRA.13081437.1498054652000@Atlassian.JIRA> <JIRA.13081437.1498054652948@jira-lw-us.apache.org>
Subject: [jira] [Created] (HADOOP-14563)
 LoadBalancingKMSClientProvider#warmUpEncryptedKeys swallows IOException
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 21 Jun 2017 14:18:05 -0000

Rushabh S Shah created HADOOP-14563:
---------------------------------------

             Summary: LoadBalancingKMSClientProvider#warmUpEncryptedKeys swallows IOException
                 Key: HADOOP-14563
                 URL: https://issues.apache.org/jira/browse/HADOOP-14563
             Project: Hadoop Common
          Issue Type: Bug
    Affects Versions: 2.8.1
            Reporter: Rushabh S Shah
            Assignee: Rushabh S Shah


TestAclsEndToEnd is failing consistently in HADOOP-14521.
The reason behind it is LoadBalancingKMSClientProvider#warmUpEncryptedKeys swallows IOException while KMSClientProvider#warmUpEncryptedKeys throws all the way back to createEncryptionZone and creation of EZ fails.
Following are the relevant piece of code snippets.
 {code:title=KMSClientProvider.java|borderStyle=solid}
  @Override
  public void warmUpEncryptedKeys(String... keyNames)
      throws IOException {
    try {
      encKeyVersionQueue.initializeQueuesForKeys(keyNames);
    } catch (ExecutionException e) {
      throw new IOException(e);
    }
  }
{code}

 {code:title=LoadBalancingKMSClientProvider.java|borderStyle=solid}
   // This request is sent to all providers in the load-balancing group
  @Override
  public void warmUpEncryptedKeys(String... keyNames) throws IOException {
    for (KMSClientProvider provider : providers) {
      try {
        provider.warmUpEncryptedKeys(keyNames);
      } catch (IOException ioe) {
        LOG.error(
            "Error warming up keys for provider with url"
            + "[" + provider.getKMSUrl() + "]", ioe);
      }
    }
  }
{code}
In HADOOP-14521, I intend to always instantiate LoadBalancingKMSClientProvider even if there is only one provider so that the retries can applied at only one place.
We need to decide whether we want to fail in both the case or continue.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org