hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "hu xiaodong (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HADOOP-14513) A little performance improvement of HarFileSystem
Date Fri, 09 Jun 2017 08:57:19 GMT
hu xiaodong created HADOOP-14513:
------------------------------------

             Summary: A little performance improvement of HarFileSystem
                 Key: HADOOP-14513
                 URL: https://issues.apache.org/jira/browse/HADOOP-14513
             Project: Hadoop Common
          Issue Type: Improvement
            Reporter: hu xiaodong
            Assignee: hu xiaodong
            Priority: Trivial


In the Java source of HarFileSystem.java:
{code:title=HarFileSystem.java|borderStyle=solid}
...................
...................
private Path archivePath(Path p) {
    Path retPath = null;
    Path tmp = p;
    
    // I think p.depth() need not be loop many times, depth() is a complex calculation
    for (int i=0; i< p.depth(); i++) {
      if (tmp.toString().endsWith(".har")) {
        retPath = tmp;
        break;
      }
      tmp = tmp.getParent();
    }
    return retPath;
  }
...................
...................
{code}
 
I think the fellow is more suitable:
{code:title=HarFileSystem.java|borderStyle=solid}
...................
...................
private Path archivePath(Path p) {
    Path retPath = null;
    Path tmp = p;
    
    // just loop once
    for (int i=0,depth=p.depth(); i< depth; i++) {
      if (tmp.toString().endsWith(".har")) {
        retPath = tmp;
        break;
      }
      tmp = tmp.getParent();
    }
    return retPath;
  }
...................
...................
{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org


Mime
View raw message