Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6C47C200BC1 for ; Wed, 2 Nov 2016 05:24:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6AE94160B07; Wed, 2 Nov 2016 04:24:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AFECE160B02 for ; Wed, 2 Nov 2016 05:24:00 +0100 (CET) Received: (qmail 14991 invoked by uid 500); 2 Nov 2016 04:23:59 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-dev@hadoop.apache.org Received: (qmail 14975 invoked by uid 99); 2 Nov 2016 04:23:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2016 04:23:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BB3032C2A6C for ; Wed, 2 Nov 2016 04:23:58 +0000 (UTC) Date: Wed, 2 Nov 2016 04:23:58 +0000 (UTC) From: "Xiao Chen (JIRA)" To: common-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HADOOP-13785) Clean up tests that conditionally handle IBM_JAVA MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 02 Nov 2016 04:24:01 -0000 Xiao Chen created HADOOP-13785: ---------------------------------- Summary: Clean up tests that conditionally handle IBM_JAVA Key: HADOOP-13785 URL: https://issues.apache.org/jira/browse/HADOOP-13785 Project: Hadoop Common Issue Type: Improvement Components: test Affects Versions: 2.8.0 Reporter: Xiao Chen Priority: Minor Initially from a [review comment|https://issues.apache.org/jira/browse/HADOOP-13590?focusedCommentId=15625141&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15625141] by [~stevel@apache.org]. In some tests we see code like below: {code} if (PlatformName.IBM_JAVA) { options.put("useKeytab", keytab.getPath()); options.put("credsType", "both"); } else { options.put("keyTab", keytab.getPath()); options.put("useKeyTab", "true"); options.put("storeKey", "true"); options.put("doNotPrompt", "true"); options.put("useTicketCache", "true"); options.put("renewTGT", "true"); options.put("isInitiator", Boolean.toString(true)); } {code} We should extract a util function to some degree, and clean them up. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-dev-help@hadoop.apache.org