hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Wang <andrew.w...@cloudera.com>
Subject Re: [DISCUSS] Commit log Pattern Unification
Date Mon, 07 Nov 2016 19:59:15 GMT
Part of why I asked this question is because it's hard to get consistent
log messages until they can be enforced via precommit. We already have the
issue of typo'd or forgotten JIRA numbers in commit messages, and that'd
happen for attribution messages as well.

There's also always significant dedupe necessary to grep correctly. Until
someone is a committer, they don't have an Apache ID. In the meanwhile you
can use their JIRA username, but that can be different from their eventual
Apache ID, and people also change their JIRA usernames and emails.

IMO, if you have a usecase that requires counting contributors, go to the
source of truth: JIRA. The releasedocmaker.py script from Yetus builds the
changelog and release notes from JIRA info, and is pretty straightforward.
You can modify that, or grep the generated markdown output. Or, if it's
gone out in a release, you can grep the changelog from the release tarball.

On Mon, Nov 7, 2016 at 11:45 AM, Ravi Prakash <ravihadoop@gmail.com> wrote:

> And sometimes there are multiple contributors, so it becomes Contributed
> by XX1, XX2 and XX3.
>
> I guess having the information in git logs makes for easy grepping, awking
> and counting ;-)
>
> On Mon, Nov 7, 2016 at 11:35 AM, Andrew Wang <andrew.wang@cloudera.com>
> wrote:
>
>> I've always done d), but isn't this information captured in JIRA anyway?
>>
>> On Mon, Nov 7, 2016 at 11:29 AM, Ravi Prakash <ravihadoop@gmail.com>
>> wrote:
>>
>>> I have a preference for d) Contributed by XXX.
>>>
>>> Wouldn't signed-off require the commit to come from the contributor? What
>>> about people who submit patch files? I thought that was still the modus
>>> operandi, no?
>>>
>>> On Sun, Nov 6, 2016 at 8:18 PM, Daniel Templeton <daniel@cloudera.com>
>>> wrote:
>>>
>>> > On 11/6/16 8:01 PM, Daniel Templeton wrote:
>>> >
>>> >> It's also how the committer is included in the log by git.
>>> >>
>>> >
>>> > OK, git actually shows name and email in the log.  It shows the
>>> username
>>> > in the annotations in NetBeans, which is what I was thinking of. :)
>>> >
>>> >
>>> > Daniel
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
>>> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
>>> >
>>> >
>>>
>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message