hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shane Kumpf <shane.kumpf.apa...@gmail.com>
Subject [DISCUSS] HADOOP-13603 - Remove package line length checkstyle rule
Date Wed, 19 Oct 2016 13:52:54 GMT
All,

I would like to start a discussion on the possibility of removing the
package line length checkstyle rule (HADOOP-13603
<https://issues.apache.org/jira/browse/HADOOP-13603>).

While working on various aspects of YARN container runtimes, all of my
pre-commit jobs would fail as the package line length exceeded 80
characters. While I'm all for automated checks, I feel checks need to be
enforceable and provide value. Fixing the package line length error does
not improve readability or maintainability of the code, and IMO should be
removed.

While on this topic, are there other automated checks that are difficult to
enforce or you feel are not providing value (perhaps the 150 line method
length)?

Please share your thoughts.

Thank you,
Shane Kumpf

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message