Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 11 Aug 2016 14:15:20 +0000 (UTC)
From: "Nemo Chen (JIRA)" <jira@apache.org>
To: common-dev@hadoop.apache.org
Message-ID: <JIRA.12996627.1470924861000.283516.1470924920850@Atlassian.JIRA>
In-Reply-To: <JIRA.12996627.1470924861000@Atlassian.JIRA>
References: <JIRA.12996627.1470924861000@Atlassian.JIRA> <JIRA.12996627.1470924861155@arcas>
Subject: [jira] [Created] (HADOOP-13484) Log refactoring: method invocation
 should be replaced by variable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 11 Aug 2016 14:15:23 -0000

Nemo Chen created HADOOP-13484:
----------------------------------

             Summary: Log refactoring: method invocation should be replaced by variable
                 Key: HADOOP-13484
                 URL: https://issues.apache.org/jira/browse/HADOOP-13484
             Project: Hadoop Common
          Issue Type: Bug
          Components: metrics
    Affects Versions: 2.7.2
            Reporter: Nemo Chen


Similar to the fix for HDFS-409. In file:

hadoop-rel-release-2.7.2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableRates.java

In code block:
{code:borderStyle=solid}
String name = method.getName();
LOG.debug(name);
try { registry.newRate(name, name, false, true); }
catch (Exception e) {
        LOG.error("Error creating rate metrics for "+ method.getName(), e);
}
{code}
method.getName() is better to be replaced by variable name.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org