hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Fabbri (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HADOOP-13559) Remove close() within try-with-resources
Date Mon, 29 Aug 2016 17:02:20 GMT
Aaron Fabbri created HADOOP-13559:
-------------------------------------

             Summary: Remove close() within try-with-resources
                 Key: HADOOP-13559
                 URL: https://issues.apache.org/jira/browse/HADOOP-13559
             Project: Hadoop Common
          Issue Type: Bug
          Components: fs
    Affects Versions: 2.8.0, 2.9.0
            Reporter: Aaron Fabbri
            Assignee: Aaron Fabbri
            Priority: Minor


My colleague noticed that HADOOP-12994 introduced to places where close() was still called
manually within a try-with-resources block.

I'll attach a patch to remove the manual close() calls. 

These extra calls to close() are probably safe, as InputStream is a Closable, not AutoClosable
(the later does not specify close() as idempotent).




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org


Mime
View raw message