Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DB3DA200B41 for ; Thu, 7 Jul 2016 16:30:02 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D9CB7160A68; Thu, 7 Jul 2016 14:30:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 07D09160A4F for ; Thu, 7 Jul 2016 16:30:01 +0200 (CEST) Received: (qmail 96066 invoked by uid 500); 7 Jul 2016 14:30:00 -0000 Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-dev@hadoop.apache.org Received: (qmail 96026 invoked by uid 99); 7 Jul 2016 14:30:00 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jul 2016 14:30:00 +0000 Received: from mail-oi0-f45.google.com (mail-oi0-f45.google.com [209.85.218.45]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 2CED01A0285; Thu, 7 Jul 2016 14:30:00 +0000 (UTC) Received: by mail-oi0-f45.google.com with SMTP id r2so25222266oih.2; Thu, 07 Jul 2016 07:30:00 -0700 (PDT) X-Gm-Message-State: ALyK8tKiGB0QxJhuZa6Ah8ZiaaxSm7wCJ535FchvCXOjwO0WspryD75nre/yXPHC/zlqoMg/Y2CNZ609OshqzQ== X-Received: by 10.157.56.193 with SMTP id k1mr312718ote.179.1467901799341; Thu, 07 Jul 2016 07:29:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.31.42 with HTTP; Thu, 7 Jul 2016 07:29:58 -0700 (PDT) In-Reply-To: References: <5BAB74C7-E27A-4F05-8173-4B38D96B743B@apache.org> From: Tsuyoshi Ozawa Date: Thu, 7 Jul 2016 23:29:58 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [DICUSS] Upgrading Guice to 4.0(HADOOP-12064) To: Ravi Prakash Cc: Tsuyoshi Ozawa , Andrew Wang , Sangjin Lee , Sean Busbey , Vinod Kumar Vavilapalli , "hdfs-dev@hadoop.apache.org" , "mapreduce-dev@hadoop.apache.org" , "common-dev@hadoop.apache.org" , "yarn-dev@hadoop.apache.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable archived-at: Thu, 07 Jul 2016 14:30:03 -0000 Thanks all for the discussion. I merged it on 2nd July :-) I think the last task about JDK 8 compilation support is to configure maven-enforcer-plugin. Thanks, - Tsuyoshi On Wed, Jul 6, 2016 at 3:41 AM, Ravi Prakash wrote: > Go Go Go! Thanks for all the upgrade work Tsuyoshi! > > On Thu, Jun 30, 2016 at 12:03 PM, Tsuyoshi Ozawa wrote= : >> >> Thanks, Andrew. >> >> Based on discussion here, I would like to merge it into *trunk* if >> there are no objection tomorrow. >> >> Thanks, >> - Tsuyoshi >> >> On Wed, Jun 29, 2016 at 12:28 PM, Andrew Wang >> wrote: >> > I think it's okay to merge. We've already bumped other deps in trunk. >> > >> > On Wed, Jun 29, 2016 at 12:27 PM, Tsuyoshi Ozawa >> > wrote: >> >> >> >> I forgot to mention about importance point: it's a blocker issue to >> >> compile Hadoop with JDK8. Hence, we need to merge it on both client >> >> side and server slide anyway. >> >> >> >> Thanks, >> >> - Tsuyoshi >> >> >> >> On Wed, Jun 29, 2016 at 12:24 PM, Tsuyoshi Ozawa >> >> wrote: >> >> > Thanks Vinod, Sangjin, Sean for your comment. >> >> > >> >> > Okay, I will take a look at the class path isolation. >> >> > Should I postpone to merge Guice upgrade to trunk? IMHO, it works >> >> > with >> >> > tests, so it's okay to merge to runk. Thoughts? >> >> > >> >> > - Tsuyoshi >> >> > >> >> > On Wed, Jun 29, 2016 at 12:10 PM, Sangjin Lee >> >> > wrote: >> >> >> Yeah it would be awesome if we can get feedback and/or suggestions >> >> >> on >> >> >> these >> >> >> JIRAs (HADOOP-11804 and HADOOP-13070). >> >> >> >> >> >> Thanks, >> >> >> Sangjin >> >> >> >> >> >> On Wed, Jun 29, 2016 at 10:55 AM, Sean Busbey >> >> >> wrote: >> >> >>> >> >> >>> At the very least, I'm running through an updated shaded hadoop >> >> >>> client >> >> >>> this week[1] (HBase is my test application and it wandered onto >> >> >>> some >> >> >>> private things that broke in branch-2). And Sangjin has a good le= ad >> >> >>> on >> >> >>> an lower-short-term-cost incremental improvement for runtime >> >> >>> isolation >> >> >>> of apps built on yarn/mapreduce[2]. He's been patiently waiting f= or >> >> >>> more review feedback. >> >> >>> >> >> >>> >> >> >>> [1]: https://issues.apache.org/jira/browse/HADOOP-11804 >> >> >>> [2]: https://issues.apache.org/jira/browse/HADOOP-13070 >> >> >>> >> >> >>> On Wed, Jun 29, 2016 at 12:33 PM, Vinod Kumar Vavilapalli >> >> >>> wrote: >> >> >>> > My strong expectation is that we=E2=80=99ll have a version of c= lasspath >> >> >>> > isolation in our first release of 3.x. I=E2=80=99m planning to = spending >> >> >>> > some >> >> >>> > cycles >> >> >>> > right away on this. >> >> >>> > >> >> >>> > Assuming classpath isolation gets in, it is reasonable to bump = up >> >> >>> > our >> >> >>> > dependencies like Jetty / Guice to the latest stable versions. >> >> >>> > >> >> >>> > Thanks >> >> >>> > +Vinod >> >> >>> > >> >> >>> >> On Jun 27, 2016, at 6:01 AM, Tsuyoshi Ozawa >> >> >>> >> wrote: >> >> >>> >> >> >> >>> >> Hi developers, >> >> >>> >> >> >> >>> >> I will plan to upgrade Google Guice dependency on trunk. The >> >> >>> >> change >> >> >>> >> also includes asm and cglib upgrade. >> >> >>> >> I checked following points: >> >> >>> >> >> >> >>> >> * Both HDFS and YARN UIs work well. >> >> >>> >> * All webIU-related tests pass as described on HADOOP-12064. >> >> >>> >> * Ran mapreduce job, and it works well. >> >> >>> >> >> >> >>> >> https://issues.apache.org/jira/browse/HADOOP-12064 >> >> >>> >> >> >> >>> >> Do you have any concern or opinion? I would like to merge it = to >> >> >>> >> trunk >> >> >>> >> on this Friday if you have no objections. >> >> >>> >> >> >> >>> >> Best, >> >> >>> >> - Tsuyoshi >> >> >>> >> >> >> >>> >> >> >> >>> >> >> >> >>> >> --------------------------------------------------------------= ------- >> >> >>> >> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.o= rg >> >> >>> >> For additional commands, e-mail: >> >> >>> >> common-dev-help@hadoop.apache.org >> >> >>> >> >> >> >>> >> >> >> >>> > >> >> >>> > >> >> >>> > >> >> >>> > >> >> >>> > ---------------------------------------------------------------= ------ >> >> >>> > To unsubscribe, e-mail: >> >> >>> > mapreduce-dev-unsubscribe@hadoop.apache.org >> >> >>> > For additional commands, e-mail: >> >> >>> > mapreduce-dev-help@hadoop.apache.org >> >> >>> > >> >> >>> >> >> >>> >> >> >>> >> >> >>> -- >> >> >>> busbey >> >> >>> >> >> >>> >> >> >>> -----------------------------------------------------------------= ---- >> >> >>> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org >> >> >>> For additional commands, e-mail: common-dev-help@hadoop.apache.or= g >> >> >>> >> >> >> >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org >> >> For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org >> >> >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org >> For additional commands, e-mail: yarn-dev-help@hadoop.apache.org >> > --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-dev-help@hadoop.apache.org