hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Zhuge (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HADOOP-13315) FileContext#umask is not initialized properly
Date Thu, 23 Jun 2016 21:13:16 GMT
John Zhuge created HADOOP-13315:
-----------------------------------

             Summary: FileContext#umask is not initialized properly
                 Key: HADOOP-13315
                 URL: https://issues.apache.org/jira/browse/HADOOP-13315
             Project: Hadoop Common
          Issue Type: Bug
            Reporter: John Zhuge
            Assignee: John Zhuge
            Priority: Minor


Notice field {{umask}} is not set to parameter {{theUmask}} and {{theUmask}} is unused.

{code:title=FileContext.java}
  private FileContext(final AbstractFileSystem defFs,
    final FsPermission theUmask, final Configuration aConf) {
    defaultFS = defFs;
    umask = FsPermission.getUMask(aConf);
    conf = aConf;
...
  public static FileContext getFileContext(final AbstractFileSystem defFS,
                    final Configuration aConf) {
    return new FileContext(defFS, FsPermission.getUMask(aConf), aConf);
  }
{code}

Proposal:
* Set {{umask}} to {{theUmask}}. Since the only caller {{getFileContext}} already passes the
same value in {{theUmask}}, there is no change in behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org


Mime
View raw message