hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Zhuge <jzh...@cloudera.com>
Subject Re: checkstyle and package-info
Date Mon, 16 May 2016 17:12:17 GMT
http://stackoverflow.com/questions/5871020/different-checkstyle-rules-for-main-and-test-in-maven
http://stackoverflow.com/questions/25894431/checkstyle-different-rules-for-different-files

So something like this for Hadoop:

<suppress checks="CheckInappropiateForTests" files="Test.*\.java"/>

I will test it this approach.


John Zhuge
Software Engineer, Cloudera

On Mon, May 16, 2016 at 9:39 AM, Chris Nauroth <cnauroth@hortonworks.com>
wrote:

> I'm in favor of disabling this, but I'm not sure how.  It looks like
> HADOOP-12701 recently enabled Checkstyle in src/test, so we hadn't seen
> this before.  Unfortunately, I can't find a way to keep Checkstyle
> generally on for src/test, but with different rules from src/main.
>
> http://checkstyle.sourceforge.net/config_javadoc.html
>
>
> Does anyone else have an idea?
>
>
> --Chris Nauroth
>
>
>
>
> On 5/16/16, 6:34 AM, "Steve Loughran" <stevel@hortonworks.com> wrote:
>
> >
> >I've got checkstyle rejecting a patch as there's no package-info.java
> >file ‹in src/test
> >
> >https://issues.apache.org/jira/browse/HADOOP-13130
> >
> >I'm happy to argue the merits of the package-info files in production
> >code: they can be good, if people put in the effort to write and
> >maintain, but not for tests. Can we get this turned off?
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message