Mailing-List: contact common-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-dev@hadoop.apache.org
Message-Id: 
 <1459814812.2284336.569004681.6101C289@webmail.messagingengine.com>
From: Colin McCabe <colin@cmccabe.xyz>
To: common-dev@hadoop.apache.org
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
In-Reply-To: 
 <CADoWKTCWWRpUH0LhAKMeLeA8BZuTW=_ewwR7jyAmoU7B+OXozQ@mail.gmail.com>
References: 
 <CAHfHakE9mtkGQap50JLsj8tFuEpOxCuva2cwqKdoVchk8xct5w@mail.gmail.com>
 <19E3715B-5663-469B-87A1-153E7B24A5E7@hortonworks.com>
 <CAGB5D2YkX-8a65N2-EyGczDSsp9M1KR575o3ZmGJPYO0XzL28g@mail.gmail.com>
 <CAKKt98SCkfm0nQATxv11m7UggqNbp__1ccqK-UcDB-2eepbeNQ@mail.gmail.com>
 <56332B13.9020904@oss.nttdata.co.jp>
 <CAHfHakGkvEZhTWPc3t10bfFqBkGwpvyfpWNitsrniD665pj+rQ@mail.gmail.com>
 <CAGB5D2YAbCA2bcqmytqJudM58Xt9mxcYFGcT2c_rfYoVTA7sDQ@mail.gmail.com>
 <5F22ADE0-D5E7-4EA2-AD26-BCC37CA40027@altiscale.com>
 <CAGHyZ6J9Y1Zhj=vGfRDc81S_Xq6N1R-BqG587hRfspNzWdf+6Q@mail.gmail.com>
 <CA+qbEUM8WUA3PmuOjkfKb-V64PSYa_4na+GfMU6hYZ9tCY_zjg@mail.gmail.com>
 <CAGB5D2ZVDN9658mAr=GXqbcrNf-S5Yznz43Xw59+p5aq3Z-ZRQ@mail.gmail.com>
 <CAHfHakGbLxg-55Eaz75rorwmrj=HAqNnEgX40gOibOZ9qzKKNQ@mail.gmail.com>
 <CACO5Y4wSovQxqqMBmDsH+W326CMfnneBsvS-zTFCDsS_qeouJA@mail.gmail.com>
 <CAHfHakFXx-irip3UqRPR4jAS9QRRFpC=d6hb6OK3KXvawDmYaQ@mail.gmail.com>
 <8307C27B-818F-4C2D-8F86-58E566A80740@hortonworks.com>
 <CA+qbEUOpffR4g60uz3w1suhfnnHkZK0rwsk9T5Xr-QjtCymrzA@mail.gmail.com>
 <12FCE5AC-15DA-4B2D-9744-DB625163ECB7@altiscale.com>
 <CA+qbEUMgqOEB-ytWsZJD7mxbyW7u=VT+pAh5evi_fpXobR0YtQ@mail.gmail.com>
 <CAGHyZ6+377zG36JiU1yWgrGFuPdVRGa42Z1sP3oQgOM9MbvkDA@mail.gmail.com>
 <CAGB5D2afZ=ncp53jRSWxN5BBJcbRFqX9XLq6UT4pRZiwHi8ghQ@mail.gmail.com>
 <CADfbTpE7fN9-DgEHmbA8GyvV1Q0LJRdkP7pRPOYNjFxq0OYi9w@mail.gmail.com>
 <CA+qbEUNMm0UhC=N+uV0UgsaN8uC40b1Y8mcTGs7JRsiL3R0N1w@mail.gmail.com>
 <CAGB5D2au6gFW16W9QSHFHONHkcCpPUSAnLe7fpzxgCJkvC9gSw@mail.gmail.com>
 <CADoWKTCWWRpUH0LhAKMeLeA8BZuTW=_ewwR7jyAmoU7B+OXozQ@mail.gmail.com>
Subject: Re: Github integration for Hadoop
Date: Mon, 04 Apr 2016 17:06:52 -0700

Yes, please.  Let's disable these mails.

C.

On Mon, Apr 4, 2016, at 06:21, Vinayakumar B wrote:
> bq. We don't spam common-dev about every time a new patch attachment
> gets posted
> to an existing JIRA.  We shouldn't do that for github either.
>=20
> Is there any update on this. ?
> Any INFRA ticket filed to disable these mails?
>=20
> Because, I am sure, people would have got frustrated by seeing mails
> generated by my recent PR submissions. And each time, when some comment
> gets added to PR.
>=20
> -Vinay
>=20
> On Tue, Nov 24, 2015 at 3:35 AM, Andrew Wang <andrew.wang@cloudera.com>
> wrote:
>=20
> > Hi Eric,
> >
> > My comment wrt GH permissions is available in context earlier in the
> > thread, pasting again here:
> >
> > =3D=3D=3D=3D=3D=3D=3D
> >
> > Great, glad to hear it. That wasn't mentioned in the email thread or on=
 the
> > INFRA ticket, and the INFRA ticket mentions these integrations:
> >
> > Commit Comment, Create, Issue Comment, Issues, Pull Request, Pull Reque=
st
> > Comment, and push, Push
> >
> > Are these the right set of permissions to disable integrating PRs? Name=
ly,
> > the "push" permissions look unnecessary. We should also disable GH issu=
es
> > since we don't want users filing issues there.
> >
> >
> > On Mon, Nov 23, 2015 at 1:59 PM, Colin P. McCabe <cmccabe@apache.org>
> > wrote:
> >
> > > We don't spam common-dev about every time a new patch attachment gets
> > > posted to an existing JIRA.  We shouldn't do that for github either.
> > >
> > > +1 to Andrew and Steve's suggestion of disabling these emails (or at
> > > least sending them to a separate list that people can opt in to).
> > >
> > > best,
> > > Colin
> > >
> > > On Sat, Nov 21, 2015 at 9:19 AM, Eric Yang <eric818@gmail.com> wrote:
> > > > Hi Andrew,
> > > >
> > > > Many Apache projects already have Github integration.  Chukwa also =
has
> > > > Github integration.  Pull request can be integrated into JIRA, i.e.
> > > > https://issues.apache.org/jira/browse/CHUKWA-783
> > > >
> > > > This allows code review process to happen at per line level on Gith=
ub,
> > or
> > > > comment on JIRA for summary of the activities.  Micro comments are
> > squash
> > > > away.  The final commit is always happening on Apache git rather th=
an
> > > > Github.  Therefore, there is no disabling required for pull request.
> > > > Primary activity is still on JIRA, and Github is only a supplement =
to
> > > make
> > > > line by line code review easy.  Overall user experience is better t=
han
> > RB
> > > > or Gerrit in my opinion.
> > > >
> > > > regards,
> > > > Eric
> > > >
> > > > On Thu, Nov 19, 2015 at 11:28 AM, Andrew Wang <
> > andrew.wang@cloudera.com>
> > > > wrote:
> > > >
> > > >> Has there been any progress on locking down the Github permissions
> > like
> > > I
> > > >> asked above? It's been about 3 weeks.
> > > >>
> > > >> Steve also just asked on another thread to turn off the emails to
> > > >> common-dev. Since we're sticking with JIRA as the source-of-truth,=
 the
> > > >> common-dev emails aren't useful.
> > > >>
> > > >> On Fri, Nov 13, 2015 at 6:59 PM, Sean Busbey <busbey@cloudera.com>
> > > wrote:
> > > >>
> > > >> > Hi Colin!
> > > >> >
> > > >> > If Yetus is working on an issue and can't tell what the intended
> > > branch
> > > >> is
> > > >> > it points folks to project specific contribution guides.
> > > >> >
> > > >> > For Hadoop, the patch naming for specific branches should be cov=
ered
> > > in
> > > >> > this section of Hadoop's contribution guide:
> > > >> >
> > > >> > http://wiki.apache.org/hadoop/HowToContribute#Naming_your_patch
> > > >> >
> > > >> > Yetus will actually support a little bit more than that guide
> > > suggests.
> > > >> If
> > > >> > a project doesn't define a URL to point people at for help in na=
ming
> > > >> > patches we default to this guide:
> > > >> >
> > > >> > https://yetus.apache.org/documentation/latest/precommit-patchnam=
es/
> > > >> >
> > > >> >
> > > >> >
> > > >> > On Fri, Nov 13, 2015 at 8:05 PM, Colin P. McCabe <
> > cmccabe@apache.org>
> > > >> > wrote:
> > > >> >
> > > >> > > Thanks, Allen, I wasn't aware that Yetus now supported testing=
 for
> > > >> > > other branches.  Is there documentation about how to name the
> > branch
> > > >> > > so it gets tested?
> > > >> > >
> > > >> > > best,
> > > >> > > Colin
> > > >> > >
> > > >> > > On Fri, Nov 13, 2015 at 7:52 AM, Allen Wittenauer <
> > aw@altiscale.com
> > > >
> > > >> > > wrote:
> > > >> > > >
> > > >> > > >> On Nov 12, 2015, at 10:55 AM, Colin P. McCabe <
> > > cmccabe@apache.org>
> > > >> > > wrote:
> > > >> > > >>
> > > >> > > >> gerrit has a button on the UI to cherry-pick to different
> > > branches.
> > > >> > > >> The button creates separate "gerrit changes" which you can =
then
> > > >> > > >> commit.  Eventually we could hook those up to Jenkins--
> > something
> > > >> > > >> which we've never been able to do for different branches wi=
th
> > the
> > > >> > > >> patch-file-based workflow.
> > > >> > > >
> > > >> > > >
> > > >> > > >         If you=E2=80=99re saying what I think you=E2=80=99re=
 saying, people have
> > > been
> > > >> > > able to submit patches via JIRA patch file attachment to major
> > > branches
> > > >> > for
> > > >> > > a few months now. Yetus closes the loop and supports pretty mu=
ch
> > any
> > > >> > branch
> > > >> > > or git hash.  (Github PRs also go to their respective branch or
> > git
> > > >> hash
> > > >> > as
> > > >> > > well.)
> > > >> > >
> > > >> >
> > > >> >
> > > >> >
> > > >> > --
> > > >> > Sean
> > > >> >
> > > >>
> > >
> >