hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Chen (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HADOOP-13048) Improvements to StatD metrics2 sink
Date Thu, 21 Apr 2016 19:24:25 GMT
Xiao Chen created HADOOP-13048:
----------------------------------

             Summary: Improvements to StatD metrics2 sink
                 Key: HADOOP-13048
                 URL: https://issues.apache.org/jira/browse/HADOOP-13048
             Project: Hadoop Common
          Issue Type: Improvement
          Components: metrics
            Reporter: Xiao Chen
            Priority: Minor


In some recent offline review of feature HADOOP-12360, [~jojochuang] has some good comments.
The feature is overall a nice feature, but can have some improvements:

- Validation should be more robust:
{code}
public void init(SubsetConfiguration conf) {
    // Get StatsD host configurations.
    final String serverHost = conf.getString(SERVER_HOST_KEY);
    final int serverPort = Integer.parseInt(conf.getString(SERVER_PORT_KEY));
{code}
- Javadoc should be more accurate:
** Inconsistency host.name v.s. hostname
** Could have better explanation regarding service name and process name
- {{StatsDSink#writeMetric}} should be private.
- Hopefully a document about this and other metric sinks.

Thanks Wei-Chiu and [~dlmarion] for the contribution!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message